Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161148AbbBCVDi (ORCPT ); Tue, 3 Feb 2015 16:03:38 -0500 Received: from cpsmtpb-ews09.kpnxchange.com ([213.75.39.14]:54751 "EHLO cpsmtpb-ews09.kpnxchange.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754103AbbBCVDh (ORCPT ); Tue, 3 Feb 2015 16:03:37 -0500 Message-ID: <1422997415.23894.44.camel@x220> Subject: Re: [PATCH] x86/raid6: correctly check for assembler capabilities From: Paul Bolle To: NeilBrown Cc: Jan Beulich , Valentin Rothberg , mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, james.t.kukunas@linux.intel.com, linux-kernel@vger.kernel.org Date: Tue, 03 Feb 2015 22:03:35 +0100 In-Reply-To: <20150204075033.25fb2317@notabene.brown> References: <54C2148E02000078000588FB@mail.emea.novell.com> <1422995490.23894.32.camel@x220> <20150204075033.25fb2317@notabene.brown> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 03 Feb 2015 21:03:35.0636 (UTC) FILETIME=[DFFF3940:01D03FF4] X-RcptDomain: vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 26 On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: > Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) > CONFIG_AS_ is reserved for assembly magic, and is never used by the the > kconfig system. > > (Well..... I might have made bits of that up, but "git grep 'config AS_'" > doesn't find anything). That's correct, there are no Kconfig symbols starting with AS_. But still, I would like to hear whether there's a reasonable chance I might convince other people to adopt my peeve. The thinking behind that peeve is, basically, that where people encounter a CONFIG_* macro they should only have to check the .config file to see how that macro was evaluated in the build that was used. Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/