Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966637AbbBCVI4 (ORCPT ); Tue, 3 Feb 2015 16:08:56 -0500 Received: from mail-ie0-f181.google.com ([209.85.223.181]:61259 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756172AbbBCVIy convert rfc822-to-8bit (ORCPT ); Tue, 3 Feb 2015 16:08:54 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Fabio Estevam , "Stefan Wahren" From: Mike Turquette In-Reply-To: Cc: "Marek Vasut" , "Zhi Li" , "Sascha Hauer" , harald@ccbib.org, "Shawn Guo" , "linux-kernel" , "linux-arm-kernel@lists.infradead.org" References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> Message-ID: <20150203210849.421.54288@quantum> User-Agent: alot/0.3.5 Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers Date: Tue, 03 Feb 2015 13:08:49 -0800 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1420 Lines: 37 Quoting Fabio Estevam (2015-01-30 11:28:32) > On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: > > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional > > clock control register is 32-bit wide, but is separated in 4 parts. > > So write instructions must not apply to more than 1 part at once. > > > > The clk init for the i.MX28 violates this restriction and all the other > > accesses on that register suggest that there isn't such a restriction. > > > > This patch restricts the access to this register to byte instructions and > > extends the comment in the init functions. > > > > Btw the imx23 init now uses a R-M-W sequence just like imx28 init > > to avoid any clock glitches. > > > > The changes has been tested with a i.MX23 and a i.MX28 board. > > > > [1] - http://cache.freescale.com/files/dsp/doc/ref_manual/IMX23RM.pdf > > [2] - http://cache.freescale.com/files/dsp/doc/ref_manual/MCIMX28RM.pdf > > > > Signed-off-by: Stefan Wahren > > Reviewed-by: Marek Vasut > > Reviewed-by: Fabio Estevam Applied to clk-next. Thanks, Mike > > Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/