Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161185AbbBCVYw (ORCPT ); Tue, 3 Feb 2015 16:24:52 -0500 Received: from mail-wi0-f173.google.com ([209.85.212.173]:60244 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161164AbbBCVYv (ORCPT ); Tue, 3 Feb 2015 16:24:51 -0500 MIME-Version: 1.0 In-Reply-To: <20150204080907.42e43bb4@notabene.brown> References: <54C2148E02000078000588FB@mail.emea.novell.com> <1422995490.23894.32.camel@x220> <20150204075033.25fb2317@notabene.brown> <1422997415.23894.44.camel@x220> <20150204080907.42e43bb4@notabene.brown> From: Valentin Rothberg Date: Tue, 3 Feb 2015 22:24:19 +0100 Message-ID: Subject: Re: [PATCH] x86/raid6: correctly check for assembler capabilities To: NeilBrown Cc: Paul Bolle , Jan Beulich , mingo@elte.hu, tglx@linutronix.de, hpa@zytor.com, james.t.kukunas@linux.intel.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1838 Lines: 45 On Tue, Feb 3, 2015 at 10:09 PM, NeilBrown wrote: > On Tue, 03 Feb 2015 22:03:35 +0100 Paul Bolle wrote: > >> On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> > Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> > CONFIG_AS_ is reserved for assembly magic, and is never used by the the >> > kconfig system. >> > >> > (Well..... I might have made bits of that up, but "git grep 'config AS_'" >> > doesn't find anything). >> >> That's correct, there are no Kconfig symbols starting with AS_. But >> still, I would like to hear whether there's a reasonable chance I might >> convince other people to adopt my peeve. >> >> The thinking behind that peeve is, basically, that where people >> encounter a CONFIG_* macro they should only have to check the .config >> file to see how that macro was evaluated in the build that was used. >> > > Personally, I don't care. A problem with those identifiers is that the CONFIG_ prefix is reserved for Kconfig features in Make and CPP syntax. The _MODULE suffix for CPP alone. Sadly, this convention is only documented in the Kconfig C code itself. Nonetheless, such cases give hard times to static analysis tools that then have to deal with such false positives. Kind regards, Valentin > But I find that developers in general are more responsive to code than to > peeves. > > So if you post a patch which makes the change that you want, then you are > more likely to get a useful response than if you just post a peeve. > It may not be the response you want of course.... > > NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/