Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932437AbbBCWXl (ORCPT ); Tue, 3 Feb 2015 17:23:41 -0500 Received: from mail-vc0-f174.google.com ([209.85.220.174]:52622 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755151AbbBCWXh (ORCPT ); Tue, 3 Feb 2015 17:23:37 -0500 MIME-Version: 1.0 In-Reply-To: References: <1421249930-21229-1-git-send-email-dinguyen@opensource.altera.com> Date: Tue, 3 Feb 2015 23:23:35 +0100 Message-ID: Subject: Re: [PATCH] mtd: denali: Disable sub-page writes in Denali NAND driver From: Richard Weinberger To: Dinh Nguyen Cc: Dinh Nguyen , Brian Norris , David Woodhouse , yamada.m@jp.panasonic.com, Josh Triplett , "linux-mtd@lists.infradead.org" , Linux List , Graham Moore Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1622 Lines: 47 On Tue, Feb 3, 2015 at 11:15 PM, Dinh Nguyen wrote: > Hi Brian, > > On Wed, Jan 14, 2015 at 9:38 AM, wrote: >> From: Graham Moore >> >> The Denali Controller IP does not support sub-page writes. >> >> Signed-off-by: Graham Moore >> Signed-off-by: Dinh Nguyen >> --- >> drivers/mtd/nand/denali.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c >> index b3b7ca1..b16b040 100644 >> --- a/drivers/mtd/nand/denali.c >> +++ b/drivers/mtd/nand/denali.c >> @@ -1565,6 +1565,9 @@ int denali_init(struct denali_nand_info *denali) >> denali->nand.options |= NAND_SKIP_BBTSCAN; >> denali->nand.ecc.mode = NAND_ECC_HW_SYNDROME; >> >> + /* no subpage writes on denali */ >> + denali->nand.options |= NAND_NO_SUBPAGE_WRITE; >> + >> /* >> * Denali Controller only support 15bit and 8bit ECC in MRST, >> * so just let controller do 15bit ECC for MLC and 8bit ECC for >> -- >> 2.2.1 >> > > Was wondering if you got a chance to look at this patch? So this driver never worked? If it worked for some users we have to make sure that your change does not break existing setups. /me thinks of UBI. -- Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/