Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755250AbbBDBMR (ORCPT ); Tue, 3 Feb 2015 20:12:17 -0500 Received: from mx4-phx2.redhat.com ([209.132.183.25]:46695 "EHLO mx4-phx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752982AbbBDBMP (ORCPT ); Tue, 3 Feb 2015 20:12:15 -0500 Date: Tue, 3 Feb 2015 20:12:08 -0500 (EST) From: Nathan Scott Reply-To: Nathan Scott To: Chen Hanxiao , "Eric W. Biederman" Cc: Serge Hallyn , containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Message-ID: <175563041.6778432.1423012328350.JavaMail.zimbra@redhat.com> In-Reply-To: <55349719.6775592.1423011445985.JavaMail.zimbra@redhat.com> Subject: Re: [resend][PATCH v9 2/3] /proc/PID/status: show all sets of pid according to ns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [10.5.82.11] X-Mailer: Zimbra 8.0.6_GA_5922 (ZimbraWebClient - FF17 (Linux)/8.0.6_GA_5922) Thread-Topic: /proc/PID/status: show all sets of pid according to ns Thread-Index: rQ2P9RyEjT+X8WGngvz+I0pFSigkjg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3893 Lines: 83 Hi Chen, Eric, Eric W. Biederman writes: > Chen Hanxiao writes: > > If some issues occurred inside a container guest, host user > > could not know which process is in trouble just by guest pid: > > [...] > > Acked-by: Serge Hallyn > > Tested-by: Serge Hallyn > > > > Signed-off-by: Chen Hanxiao > > Acked-by: "Eric W. Biederman" > > At a quick review and read through this looks good. Once I finish > clearing the security bug fixes from my tree I will see about picking > this up. I recently came across a need for this patch so I just wanted to say thanks and since I've used it a fair bit feel free to add: Tested-by: Nathan Scott One small tweak you could make is to drop the extra whitespace from those new seq_printf calls - "\t%d " has a trailing space that isn't needed. Also there's proc status docs below Documentation/ that should be updated for these changes. They are slightly out-of-date already and there's a few typos in the vicinity - something like this may do the trick though ... ? (will need to be updated at merge time with the correct kernel version) docs: add missing and new /proc/PID/status file entries, fix typos Signed-off-by: Nathan Scott diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt index aae9dd1..457cebd 100644 --- a/Documentation/filesystems/proc.txt +++ b/Documentation/filesystems/proc.txt @@ -197,12 +197,12 @@ contains details information about the process itself. Its fields are explained in Table 1-4. (for SMP CONFIG users) -For making accounting scalable, RSS related information are handled in -asynchronous manner and the vaule may not be very precise. To see a precise +For making accounting scalable, RSS related information are handled in an +asynchronous manner and the value may not be very precise. To see a precise snapshot of a moment, you can see /proc//smaps file and scan page table. It's slow but very precise. -Table 1-2: Contents of the status files (as of 2.6.30-rc7) +Table 1-2: Contents of the status files (as of 3.20.0) .............................................................................. Field Content Name filename of the executable @@ -210,6 +210,7 @@ Table 1-2: Contents of the status files (as of 2.6.30-rc7) in an uninterruptible wait, Z is zombie, T is traced or stopped) Tgid thread group ID + Ngid NUMA group ID (0 if none) Pid process id PPid process id of the parent process TracerPid PID of process tracing this process (0 if not) @@ -217,6 +218,10 @@ Table 1-2: Contents of the status files (as of 2.6.30-rc7) Gid Real, effective, saved set, and file system GIDs FDSize number of file descriptor slots currently allocated Groups supplementary group list + NStgid descendant namespace thread group ID hierarchy + NSpid descendant namespace process ID hierarchy + NSpgid descendant namespace process group ID hierarchy + NSsid descendant namespace session ID hierarchy VmPeak peak virtual memory size VmSize total program size VmLck locked memory size -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/