Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754371AbbBDDdQ (ORCPT ); Tue, 3 Feb 2015 22:33:16 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:45962 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751693AbbBDDdP (ORCPT ); Tue, 3 Feb 2015 22:33:15 -0500 Message-ID: <54D192EE.6070302@roeck-us.net> Date: Tue, 03 Feb 2015 19:33:02 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Leonid Yegoshin , Ralf Baechle CC: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, Atsushi Nemoto , Matthew Wilcox Subject: Re: mips: Re-introduce copy_user_page References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> <54D11608.2070408@imgtec.com> In-Reply-To: <54D11608.2070408@imgtec.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020201.54D192FA.009D,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1399 Lines: 31 On 02/03/2015 10:40 AM, Leonid Yegoshin wrote: > On 01/30/2015 09:23 PM, Guenter Roeck wrote: >> Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced >> the inline function copy_user_page for mips with an external reference, >> but neglected to introduce the actual non-inline function. Restore it. >> >> Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") >> Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") >> Cc: Atsushi Nemoto >> Cc: Matthew Wilcox >> Signed-off-by: Guenter Roeck >> > > Why do you use copy_user_page? > It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. > > You should use copy_user_highpage() for user pages. > Then maybe mips should not declare it the function external, the commit log of the patch removing it should have mentioned that and why it was removed, and there should be a clear statement somewhere stating that copy_user_page shall not be used. I don't find such a statement anywhere in the kernel. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/