Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309AbbBDFQU (ORCPT ); Wed, 4 Feb 2015 00:16:20 -0500 Received: from us01smtprelay-2.synopsys.com ([198.182.60.111]:49336 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750826AbbBDFQS convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 00:16:18 -0500 From: Vineet Gupta To: Peter Hurley , Greg Kroah-Hartman CC: "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Stephen Rothwell" , Vineet Gupta , Guenter Roeck Subject: Re: [PATCH -next] ARC: Fix earlycon build breakage Thread-Topic: [PATCH -next] ARC: Fix earlycon build breakage Thread-Index: AQHQQBc1mcIiXoVM3EaPCw6YtnIA0w== Date: Wed, 4 Feb 2015 05:15:59 +0000 Message-ID: References: <1423012132-9149-1-git-send-email-peter@hurleysoftware.com> Accept-Language: en-US, en-IN Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.12.196.223] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1762 Lines: 51 On Wednesday 04 February 2015 06:39 AM, Peter Hurley wrote: > Commit ffb7fcd66f14 ("ARC: Dynamically determine BASE_BAUD from DeviceTree") > breaks arc:defconfig build: > > drivers/built-in.o: In function `of_setup_earlycon': > (.init.text+0xb3e): undefined reference to `arc_early_base_baud' > drivers/built-in.o: In function `setup_earlycon': > (.init.text+0xcd0): undefined reference to `arc_early_base_baud' > make: *** [vmlinux] Error 1 > > BASE_BAUD is only required for earlycon, which should depend on > CONFIG_SERIAL_EARLYCON. > > Reported-by: Guenter Roeck > Tested-by: Guenter Roeck > Signed-off-by: Peter Hurley /Me slaps myself :-( Thx for the quick fix Peter. Now applied to my for-next and also quickly tested on simulator. FWIW, the issue came about because defconfig doesn't use the 8250 uart driver, rather the legacy arc uart which still uses earlycon - but I still can't fathom why i didn't see it earlier. Thx, -Vineet > --- > arch/arc/kernel/devtree.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arc/kernel/devtree.c b/arch/arc/kernel/devtree.c > index 5036d4c..e32b54a 100644 > --- a/arch/arc/kernel/devtree.c > +++ b/arch/arc/kernel/devtree.c > @@ -17,7 +17,7 @@ > #include > #include > > -#ifdef CONFIG_SERIAL_8250_CONSOLE > +#ifdef CONFIG_SERIAL_EARLYCON > > static unsigned int __initdata arc_base_baud; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/