Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932454AbbBDHwG (ORCPT ); Wed, 4 Feb 2015 02:52:06 -0500 Received: from mail.emea.novell.com ([130.57.118.101]:43297 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751287AbbBDHwD convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 02:52:03 -0500 Message-Id: <54D1DDAD020000780005CA8E@mail.emea.novell.com> X-Mailer: Novell GroupWise Internet Agent 14.0.1 Date: Wed, 04 Feb 2015 07:51:57 +0000 From: "Jan Beulich" To: "Paul Bolle" Cc: , "Valentin Rothberg" , , , "NeilBrown" , , Subject: Re: [PATCH] x86/raid6: correctly check for assembler capabilities References: <54C2148E02000078000588FB@mail.emea.novell.com> <1422995490.23894.32.camel@x220> <20150204075033.25fb2317@notabene.brown> <1422997415.23894.44.camel@x220> In-Reply-To: <1422997415.23894.44.camel@x220> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8BIT Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1340 Lines: 30 >>> On 03.02.15 at 22:03, wrote: > On Wed, 2015-02-04 at 07:50 +1100, NeilBrown wrote: >> Actually the prefix of this macro is "CONFIG_AS_", not "CONFIG_" :-) >> CONFIG_AS_ is reserved for assembly magic, and is never used by the the >> kconfig system. >> >> (Well..... I might have made bits of that up, but "git grep 'config AS_'" >> doesn't find anything). > > That's correct, there are no Kconfig symbols starting with AS_. But > still, I would like to hear whether there's a reasonable chance I might > convince other people to adopt my peeve. > > The thinking behind that peeve is, basically, that where people > encounter a CONFIG_* macro they should only have to check the .config > file to see how that macro was evaluated in the build that was used. I too found it curious that CONFIG_* is being used here instead of e.g. HAVE_*, but with the patch at hand I simply followed suit (as that normally is the route involving less discussions in order to get a necessary/desirable fix accepted). In the end I guess you'd need to convince the x86 maintainers. Jan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/