Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965570AbbBDMv2 (ORCPT ); Wed, 4 Feb 2015 07:51:28 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:41256 "EHLO mail-we0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932530AbbBDMvZ (ORCPT ); Wed, 4 Feb 2015 07:51:25 -0500 MIME-Version: 1.0 In-Reply-To: <1423053695.907.117.camel@edumazet-glaptop2.roam.corp.google.com> References: <1423052746-3688-1-git-send-email-prabhakar.csengg@gmail.com> <1423053695.907.117.camel@edumazet-glaptop2.roam.corp.google.com> From: "Lad, Prabhakar" Date: Wed, 4 Feb 2015 12:50:53 +0000 Message-ID: Subject: Re: [PATCH] net: core/dev: fix sparse warning To: Eric Dumazet Cc: "David S. Miller" , netdev , LKML , Eric Dumazet Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1507 Lines: 41 On Wed, Feb 4, 2015 at 12:41 PM, Eric Dumazet wrote: > On Wed, 2015-02-04 at 12:25 +0000, Lad Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> this patch fixes following sparse warning: >> net/core/dev.c: In function 'validate_xmit_skb_list': >> net/core/dev.c:2720: warning: 'tail' may be used uninitialized in this function >> >> Although its a false positive, as head is assigned to NULL in the >> beginning, due which later in the loop tail is assigned to skb->prev. >> >> Signed-off-by: Lad, Prabhakar >> --- >> net/core/dev.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/net/core/dev.c b/net/core/dev.c >> index 8ce0d1a..c736467 100644 >> --- a/net/core/dev.c >> +++ b/net/core/dev.c >> @@ -2717,7 +2717,7 @@ out_null: >> >> struct sk_buff *validate_xmit_skb_list(struct sk_buff *skb, struct net_device *dev) >> { >> - struct sk_buff *next, *head = NULL, *tail; >> + struct sk_buff *next, *head = NULL, *tail = NULL; >> >> for (; skb != NULL; skb = next) { >> next = skb->next; > > Which gcc/sparse versions are you using ? > I tried it on gcc 4.3.3 and sparse with 0.4.5-rc1 version. Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/