Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755315AbbBDN6V (ORCPT ); Wed, 4 Feb 2015 08:58:21 -0500 Received: from mail-lb0-f172.google.com ([209.85.217.172]:57473 "EHLO mail-lb0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbbBDN6U (ORCPT ); Wed, 4 Feb 2015 08:58:20 -0500 From: Ivan Khoronzhuk To: linux-kernel@vger.kernel.org, matt.fleming@intel.com, ard.biesheuvel@linaro.org Cc: leif.lindholm@linaro.org, Ivan Khoronzhuk Subject: [Patch] firmware: dmi_scan: fix dmi scan to handle "End of Table" structure Date: Wed, 4 Feb 2015 15:57:45 +0200 Message-Id: <1423058265-23032-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 41 The dmi-sysfs should create "End of Table" entry, that is type 127. But after adding initial SMBIOS v3 support the 127-0 entry is not handled any more, as result it's not created in sysfs. This is important because the size of whole DMI table must correspond to sum of all DMI entry sizes. Of-course, it can be handled in newly introduced libdmifs by adding end entry virtually, but it's brake backward compatibility and don't correspond to SMBIOS DMI table size read from SMBIOS entry point structure. Signed-off-by: Ivan Khoronzhuk --- drivers/firmware/dmi_scan.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c index c5f7b4e..c63e5e5 100644 --- a/drivers/firmware/dmi_scan.c +++ b/drivers/firmware/dmi_scan.c @@ -93,12 +93,6 @@ static void dmi_table(u8 *buf, int len, int num, const struct dmi_header *dm = (const struct dmi_header *)data; /* - * 7.45 End-of-Table (Type 127) [SMBIOS reference spec v3.0.0] - */ - if (dm->type == DMI_ENTRY_END_OF_TABLE) - break; - - /* * We want to know the total length (formatted area and * strings) before decoding to make sure we won't run off the * table in dmi_decode or dmi_string -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/