Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933797AbbBDOao (ORCPT ); Wed, 4 Feb 2015 09:30:44 -0500 Received: from cantor2.suse.de ([195.135.220.15]:47381 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754632AbbBDOan (ORCPT ); Wed, 4 Feb 2015 09:30:43 -0500 Message-ID: <54D22D10.2040502@suse.de> Date: Wed, 04 Feb 2015 15:30:40 +0100 From: Alexander Graf User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Gibson , benh@kernel.crashing.org, mpe@ellerman.id.au, paulus@samba.org CC: aik@ozlabs.ru, mdroth@us.ibm.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] powerpc: Cleanup KVM emulated load/store endian handling References: <1422941785-22557-1-git-send-email-david@gibson.dropbear.id.au> <1422941785-22557-5-git-send-email-david@gibson.dropbear.id.au> In-Reply-To: <1422941785-22557-5-git-send-email-david@gibson.dropbear.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 29 On 03.02.15 06:36, David Gibson wrote: > Sometimes the KVM code on powerpc needs to emulate load or store > instructions from the guest, which can include both normal and byte > reversed forms. > > We currently (AFAICT) handle this correctly, but some variable names are > very misleading. In particular we use "is_bigendian" in several places to > actually mean "is the IO the same endian as the host", but we now support > little-endian powerpc hosts. This also ties into the misleadingly named > ld_le*() and st_le*() functions, which in fact always byteswap, even on > an LE host. > > This patch cleans this up by renaming to more accurate "host_swabbed", and > uses the generic swab*() functions instead of the powerpc specific and > misleadingly named ld_le*() and st_le*() functions. > > Signed-off-by: David Gibson Reviewed-by: Alexander Graf Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/