Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934145AbbBDPK1 (ORCPT ); Wed, 4 Feb 2015 10:10:27 -0500 Received: from 8bytes.org ([81.169.241.247]:59931 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932995AbbBDPK0 (ORCPT ); Wed, 4 Feb 2015 10:10:26 -0500 From: Joerg Roedel To: iommu@lists.linux-foundation.org Cc: Peter Zijlstra , Benjamin LaHaise , Jesse Barnes , linux-aio@kvack.org, linux-kernel@vger.kernel.org, Oded Gabbay , jroedel@suse.de, joro@8bytes.org Subject: [PATCH] iommu/amd: Use wait_event in put_pasid_state_wait Date: Wed, 4 Feb 2015 16:10:22 +0100 Message-Id: <1423062622-28257-1-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 39 From: Joerg Roedel Now that I learned about possible spurious wakeups this place needs fixing too. Replace the self-coded sleep variant with the generic wait_event() helper. Signed-off-by: Joerg Roedel --- drivers/iommu/amd_iommu_v2.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/iommu/amd_iommu_v2.c b/drivers/iommu/amd_iommu_v2.c index b6398d7..5cc1409 100644 --- a/drivers/iommu/amd_iommu_v2.c +++ b/drivers/iommu/amd_iommu_v2.c @@ -266,14 +266,7 @@ static void put_pasid_state(struct pasid_state *pasid_state) static void put_pasid_state_wait(struct pasid_state *pasid_state) { - DEFINE_WAIT(wait); - - prepare_to_wait(&pasid_state->wq, &wait, TASK_UNINTERRUPTIBLE); - - if (!atomic_dec_and_test(&pasid_state->count)) - schedule(); - - finish_wait(&pasid_state->wq, &wait); + wait_event(pasid_state->wq, !atomic_read(&pasid_state->count)); free_pasid_state(pasid_state); } -- 1.8.4.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/