Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966449AbbBDQBu (ORCPT ); Wed, 4 Feb 2015 11:01:50 -0500 Received: from mail-wi0-f177.google.com ([209.85.212.177]:53952 "EHLO mail-wi0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755526AbbBDQBs (ORCPT ); Wed, 4 Feb 2015 11:01:48 -0500 MIME-Version: 1.0 In-Reply-To: <1423051446-30090-1-git-send-email-prabhakar.csengg@gmail.com> References: <1423051446-30090-1-git-send-email-prabhakar.csengg@gmail.com> From: Rob Herring Date: Wed, 4 Feb 2015 10:01:26 -0600 Message-ID: Subject: Re: [PATCH] of/fdt: fix sparse warning To: Lad Prabhakar Cc: Grant Likely , Rob Herring , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 41 On Wed, Feb 4, 2015 at 6:04 AM, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > fdt.c:765:12: warning: symbol 'early_init_dt_scan_chosen_serial' was not declared. Should it be static? > > Signed-off-by: Lad, Prabhakar Applied, thanks. Rob > --- > Found this issue on linux-next and applies on top linux-next. > > drivers/of/fdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c > index 5100742..3a896c9 100644 > --- a/drivers/of/fdt.c > +++ b/drivers/of/fdt.c > @@ -762,7 +762,7 @@ static inline void early_init_dt_check_for_initrd(unsigned long node) > #ifdef CONFIG_SERIAL_EARLYCON > extern struct of_device_id __earlycon_of_table[]; > > -int __init early_init_dt_scan_chosen_serial(void) > +static int __init early_init_dt_scan_chosen_serial(void) > { > int offset; > const char *p; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/