Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966799AbbBDQZf (ORCPT ); Wed, 4 Feb 2015 11:25:35 -0500 Received: from mga01.intel.com ([192.55.52.88]:55007 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965319AbbBDQZe convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 11:25:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,518,1418112000"; d="scan'208";a="522505122" From: "Wilcox, Matthew R" To: Leonid Yegoshin , Guenter Roeck , Ralf Baechle CC: "linux-mips@linux-mips.org" , "linux-kernel@vger.kernel.org" , Atsushi Nemoto Subject: RE: mips: Re-introduce copy_user_page Thread-Topic: mips: Re-introduce copy_user_page Thread-Index: AQHQP+Dc9wfYcGSMQU6+AGJBA2rhxpzfTD2w Date: Wed, 4 Feb 2015 16:25:08 +0000 Message-ID: <100D68C7BA14664A8938383216E40DE04085641F@FMSMSX114.amr.corp.intel.com> References: <1422681807-28395-1-git-send-email-linux@roeck-us.net> <54D11608.2070408@imgtec.com> In-Reply-To: <54D11608.2070408@imgtec.com> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.107] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 34 There is no 'struct page' for the source of this data. We have a kernel address for it; that's all. -----Original Message----- From: Leonid Yegoshin [mailto:Leonid.Yegoshin@imgtec.com] Sent: Tuesday, February 03, 2015 10:40 AM To: Guenter Roeck; Ralf Baechle Cc: linux-mips@linux-mips.org; linux-kernel@vger.kernel.org; Atsushi Nemoto; Wilcox, Matthew R Subject: Re: mips: Re-introduce copy_user_page On 01/30/2015 09:23 PM, Guenter Roeck wrote: > Commit bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") replaced > the inline function copy_user_page for mips with an external reference, > but neglected to introduce the actual non-inline function. Restore it. > > Fixes: bcd022801ee5 ("MIPS: Fix COW D-cache aliasing on fork") > Fixes: 4927b7d77c00 ("dax,ext2: replace the XIP page fault handler with the DAX page fault handler") > Cc: Atsushi Nemoto > Cc: Matthew Wilcox > Signed-off-by: Guenter Roeck > Why do you use copy_user_page? It doesn't work properly in HIGHMEM environment and it is excluded from MIPS because of that, I believe. You should use copy_user_highpage() for user pages. - Leonid. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/