Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161492AbbBDS1s (ORCPT ); Wed, 4 Feb 2015 13:27:48 -0500 Received: from mail-wg0-f44.google.com ([74.125.82.44]:53133 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161333AbbBDS1q (ORCPT ); Wed, 4 Feb 2015 13:27:46 -0500 From: Lad Prabhakar To: Greg Kroah-Hartman , Jiri Slaby Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] tty/sysrq: fix sparse warnings Date: Wed, 4 Feb 2015 18:27:31 +0000 Message-Id: <1423074451-7147-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1345 Lines: 37 From: "Lad, Prabhakar" this patch fixes following sparse warnings: sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static? sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/tty/sysrq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c index 259a4d5..d272a37 100644 --- a/drivers/tty/sysrq.c +++ b/drivers/tty/sysrq.c @@ -55,8 +55,8 @@ static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE; static bool __read_mostly sysrq_always_enabled; -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; -int sysrq_reset_downtime_ms __weak; +static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; +static int sysrq_reset_downtime_ms __weak; static bool sysrq_on(void) { -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/