Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161672AbbBDS4n (ORCPT ); Wed, 4 Feb 2015 13:56:43 -0500 Received: from mail-wi0-f175.google.com ([209.85.212.175]:39721 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161243AbbBDS4k convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 13:56:40 -0500 MIME-Version: 1.0 In-Reply-To: <1423074451-7147-1-git-send-email-prabhakar.csengg@gmail.com> References: <1423074451-7147-1-git-send-email-prabhakar.csengg@gmail.com> From: "Lad, Prabhakar" Date: Wed, 4 Feb 2015 18:56:08 +0000 Message-ID: Subject: Re: [PATCH] tty/sysrq: fix sparse warnings To: Greg Kroah-Hartman , Jiri Slaby Cc: LKML , "Lad, Prabhakar" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1934 Lines: 52 On Wed, Feb 4, 2015 at 6:27 PM, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warnings: > sysrq.c:58:16: warning: symbol 'platform_sysrq_reset_seq' was not declared. Should it be static? > sysrq.c:59:5: warning: symbol 'sysrq_reset_downtime_ms' was not declared. Should it be static? > Sorry for the nose please drop this patch, it causes build failure, drivers/tty/sysrq.c:58:23: error: weak declaration of ‘platform_sysrq_reset_seq’ must be public static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; ^ drivers/tty/sysrq.c:59:12: error: weak declaration of ‘sysrq_reset_downtime_ms’ must be public static int sysrq_reset_downtime_ms __weak; ^ Cheers, --Prabhakar Lad > Signed-off-by: Lad, Prabhakar > --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/tty/sysrq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/sysrq.c b/drivers/tty/sysrq.c > index 259a4d5..d272a37 100644 > --- a/drivers/tty/sysrq.c > +++ b/drivers/tty/sysrq.c > @@ -55,8 +55,8 @@ > static int __read_mostly sysrq_enabled = CONFIG_MAGIC_SYSRQ_DEFAULT_ENABLE; > static bool __read_mostly sysrq_always_enabled; > > -unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; > -int sysrq_reset_downtime_ms __weak; > +static unsigned short platform_sysrq_reset_seq[] __weak = { KEY_RESERVED }; > +static int sysrq_reset_downtime_ms __weak; > > static bool sysrq_on(void) > { > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/