Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934188AbbBDUmY (ORCPT ); Wed, 4 Feb 2015 15:42:24 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:56349 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934120AbbBDUmX convert rfc822-to-8bit (ORCPT ); Wed, 4 Feb 2015 15:42:23 -0500 MIME-Version: 1.0 In-Reply-To: References: <1422970639-7922-1-git-send-email-daniel.sanders@imgtec.com> <1422970639-7922-2-git-send-email-daniel.sanders@imgtec.com> <54D27403.90000@iki.fi> Date: Wed, 4 Feb 2015 22:42:22 +0200 X-Google-Sender-Auth: Fav94Uo_HMyrL0DwZA6JPqHcc5k Message-ID: Subject: Re: [PATCH 1/5] LLVMLinux: Correct size_index table before replacing the bootstrap kmem_cache_node. From: Pekka Enberg To: Daniel Sanders Cc: Christoph Lameter , David Rientjes , Joonsoo Kim , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1011 Lines: 14 On Wed, Feb 4, 2015 at 10:38 PM, Daniel Sanders wrote: > I don't believe the bug to be LLVM specific but GCC doesn't normally encounter the problem. I haven't been able to identify exactly what GCC is doing better (probably inlining) but it seems that GCC is managing to optimize to the point that it eliminates the problematic allocations. This theory is supported by the fact that GCC can be made to fail in the same way by changing inline, __inline, __inline__, and __always_inline in include/linux/compiler-gcc.h such that they don't actually inline things. OK, makes sense. Please include that explanation in the changelog and drop use proper "slab" prefix instead of the confusing "LLVMLinux" prefix in the subject line. - Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/