MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.11.1502041555500.26435@gentwo.org>
References: <alpine.DEB.2.11.1502041242380.17411@gentwo.org>
 <CALCETrVXmtotCzgw8G4M6u-LrLNMjtzBsTwp4P3M4BLg=muw-g@mail.gmail.com>
 <20150204211617.GA20787@mail.hallyn.com> <CALCETrXJ3es8_wHr-ZSvqVbwdTam0AiP17axu7R8wYaVw4y-jw@mail.gmail.com>
 <alpine.DEB.2.11.1502041555500.26435@gentwo.org>
From: Andy Lutomirski <luto@amacapital.net>
Date: Wed, 4 Feb 2015 14:29:55 -0800
Message-ID: <CALCETrU+u1yL3TsOVRKqRV6c=vXY1CU2V0xc2cgjabM1ys8DBw@mail.gmail.com>
Subject: Re: [RFC] Implement ambient capability set.
To: Christoph Lameter <cl@linux.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
        "Andrew G. Morgan" <morgan@kernel.org>,
        Serge Hallyn <serge.hallyn@ubuntu.com>,
        Serge Hallyn <serge.hallyn@canonical.com>,
        Jonathan Corbet <corbet@lwn.net>, Aaron Jones <aaronmdjones@gmail.com>,
        "Ted Ts'o" <tytso@mit.edu>,
        LSM List <linux-security-module@vger.kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1268
Lines: 29

On Wed, Feb 4, 2015 at 1:57 PM, Christoph Lameter <cl@linux.com> wrote:
> On Wed, 4 Feb 2015, Andy Lutomirski wrote:
>
>> But someone will want to run *bash* as an untrusted user with, say,
>> CAP_NET_BIND permitted and ambient.  Then that user has a non-empty
>> ambient set, and they can run a setuid-root program, and who knows
>> what will go wrong?  Requiring no_new_privs would prevent this type of
>> failure entirely.
>>
>> If we need to relax that later, it's easy, I think.  The rule's not
>> that convoluted, and there's precedent for having new fancy features
>> require setting no_new_privs first.
>
> It would make the patch pointless. The case of having to run a setuid root
> prpgrams from a shell that has the caps enabled is a routine thing for
> testing etc.
>

That's unfortunate.  In that case, we need to figure out what happens
when you run such a setuid root program.  I think the answer should be
that pA gets cleared, and that pA also gets cleared if you run a
program that has file caps.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/