Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756371AbbBEB7y (ORCPT ); Wed, 4 Feb 2015 20:59:54 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:51274 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751763AbbBEB7x (ORCPT ); Wed, 4 Feb 2015 20:59:53 -0500 Date: Thu, 5 Feb 2015 01:59:45 +0000 From: Mark Brown To: Tim Bird Cc: lgirdwood@gmail.com, "linux-kernel@vger.kernel.org" , Bjorn Andersson Message-ID: <20150205015945.GQ21293@sirena.org.uk> References: <54D2A91D.5090700@sonymobile.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Lr+2STJHqvb36H87" Content-Disposition: inline In-Reply-To: <54D2A91D.5090700@sonymobile.com> X-Cookie: My LESLIE GORE record is BROKEN ... User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: Support different config and dev of_nodes in regulator_register X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2252 Lines: 60 --Lr+2STJHqvb36H87 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 04, 2015 at 03:19:57PM -0800, Tim Bird wrote: > Support calling regulator_register with a dev node and a config node > with different of_nodes. This is useful when a single driver > wishes to register multiple child regulators. > Without this you get silent failures allocating a supply > for a regulator which is registered using the device node of the > regulator's DT parent (but it's own DT node). This is explicitly not supported; such bindings are invariably attempts to encode the Linux MFD structure into the device tree (which isn't a wonderful idea as the way we split things into subsystems can and does change) or... > charger@1000 { > compatible = "qcom,pm8941-charger"; > reg = <0x1000 0x700>; > .... > chg_otg { > regulator_name = "chg_otg"; > otg-supply = <&pm8941_mvs1>; > ... > } > } ...this which just looks like the supply has been placed in the wrong place, it should be in the parent node. Supplies are always defined at the package level, that way we can consistently define the bindings for supplies for a device without having to completely support it and we don't have to bind the same supply multiple times. It should really be possible to wire up the supplies based only on the schematics. --Lr+2STJHqvb36H87 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU0s6QAAoJECTWi3JdVIfQkosH+gPomJnwhflzgxKaUgyCs/nq P7CEo32lUBe5jr80IeHuCSahxcRXiI4lNAcPq+PM9Bw2W4hkOoaoWRPz/GinZ3BU oaZ65xY938F1GAAsLqOdDQ+p9PvbMKg2ds0BaD9F7Xq2quozyiQf8UFFxg9F5ymn r3gMPkvOj/UfqOsl1gkRqFHS1MdRE8Eku0nLWBg+g0fLjm3FJRKwGgpkC8DRocmk SAlnd0rMgI2WOIr3Nb/i8rQXw3YeTIfAG8HMB35dUdAM747v+Ha5MjV2ZE0xIww4 MmRqs7/tKAaYgduWoZAsUCx82+XtQKVyR6gCFHn+6cXYumdaq2tWPAO6BD1WDYQ= =74Wk -----END PGP SIGNATURE----- --Lr+2STJHqvb36H87-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/