Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755000AbbBEDTX (ORCPT ); Wed, 4 Feb 2015 22:19:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753975AbbBEDTW (ORCPT ); Wed, 4 Feb 2015 22:19:22 -0500 Date: Thu, 5 Feb 2015 11:18:46 +0800 From: Dave Young To: Borislav Petkov Cc: Matt Fleming , Jon Masters , Laszlo Ersek , linux-efi , Ard Biesheuvel , Matt Fleming , Ricardo Neri , lkml Subject: Re: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline Message-ID: <20150205031846.GA1903@darkstar.redhat.com> References: <20141209095843.GA3990@pd.tnic> <20141210021741.GA3280@darkstar.nay.redhat.com> <20141210104627.GA17053@pd.tnic> <20150105140332.GB3163@console-pimps.org> <54AAA723.1070605@redhat.com> <54BF3DCA.4070708@jonmasters.org> <20150121100633.GC12173@pd.tnic> <20150126104936.GB3320@codeblueprint.co.uk> <20150130164309.GG1451@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150130164309.GG1451@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1970 Lines: 56 On 01/30/15 at 05:43pm, Borislav Petkov wrote: > From: Borislav Petkov > Date: Mon, 26 Jan 2015 19:49:59 +0100 > Subject: [PATCH] efi, x86: Add a "debug" option to the efi= cmdline > > ... and hide the memory regions dump behind it. Make it default-off. > > Signed-off-by: Borislav Petkov > Link: http://lkml.kernel.org/r/20141209095843.GA3990@pd.tnic > --- > arch/x86/platform/efi/efi.c | 5 ++++- > include/linux/efi.h | 1 + > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c > index dbc8627a5cdf..e859d56ce9f8 100644 > --- a/arch/x86/platform/efi/efi.c > +++ b/arch/x86/platform/efi/efi.c > @@ -491,7 +491,8 @@ void __init efi_init(void) > if (efi_memmap_init()) > return; > > - print_efi_memmap(); > + if (efi_enabled(EFI_DBG)) > + print_efi_memmap(); > } > > void __init efi_late_init(void) > @@ -939,6 +940,8 @@ static int __init arch_parse_efi_cmdline(char *str) > { > if (parse_option_str(str, "old_map")) > set_bit(EFI_OLD_MEMMAP, &efi.flags); > + if (parse_option_str(str, "debug")) > + set_bit(EFI_DBG, &efi.flags); > > return 0; > } > diff --git a/include/linux/efi.h b/include/linux/efi.h > index 0238d612750e..14cec75d7e74 100644 > --- a/include/linux/efi.h > +++ b/include/linux/efi.h > @@ -940,6 +940,7 @@ extern int __init efi_setup_pcdp_console(char *); > #define EFI_64BIT 5 /* Is the firmware 64-bit? */ > #define EFI_PARAVIRT 6 /* Access is via a paravirt interface */ > #define EFI_ARCH_1 7 /* First arch-specific bit */ > +#define EFI_DBG 8 /* Print additional debug info at runtime */ Boris, a nickpick about alignment of the second column.. Thanks Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/