Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756037AbbBEHvk (ORCPT <rfc822;w@1wt.eu>);
	Thu, 5 Feb 2015 02:51:40 -0500
Received: from mailout1.samsung.com ([203.254.224.24]:15371 "EHLO
	mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753418AbbBEHvi (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 5 Feb 2015 02:51:38 -0500
X-AuditID: cbfee61a-f79c06d000004e71-7f-54d321072b8e
From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
References: <1422917479-36393-1-git-send-email-jaegeuk@kernel.org>
In-reply-to: <1422917479-36393-1-git-send-email-jaegeuk@kernel.org>
Subject: RE: [f2fs-dev] [PATCH 1/2] f2fs: keep PagePrivate during releasepage
Date: Thu, 05 Feb 2015 15:50:49 +0800
Message-id: <005c01d04118$9042c5a0$b0c850e0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-index: AQIHvrMT+QX+YrXIB+rLUNLHHq77Ppxw2r3Q
Content-language: zh-cn
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t9jAV12xcshBltPSVk8WT+L2eLSIneL
	PXtPslhc3jWHzYHFY9OqTjaP3Qs+M3l83iQXwBzFZZOSmpNZllqkb5fAlXFyxgHmgttcFae7
	DzA3MPZxdjFyckgImEjs7VvLBmGLSVy4tx7MFhJYxCjRsiyii5ELyP7BKPF+/hdmkASbgIrE
	8o7/TCAJEYFeRokfZ/qZITqcJF62fWMFsTkFnCVWT9wFZgsL+Eo8nf6aEcRmEVCVWHv9DzuI
	zStgKdE6YSkThC0o8WPyPRYQm1lAS2L9zuNMELa8xOY1b5khrlOQ2HEWYo6IgJHE1Y0/2SBq
	xCU2HrnFMoFRcBaSUbOQjJqFZNQsJC0LGFlWMYqmFiQXFCel5xrqFSfmFpfmpesl5+duYgSH
	+DOpHYwrGywOMQpwMCrx8FruuxQixJpYVlyZe4hRgoNZSYRXk+NyiBBvSmJlVWpRfnxRaU5q
	8SFGaQ4WJXFeJfu2ECGB9MSS1OzU1ILUIpgsEwenVANjw503eov7FszWXPz1qu0C9xdySXnn
	TjLP17380O/lF+vDrYereQMMJb33vdn9JWVKrMTOmXPXrHw5JcZOahHPRIm7t6+luiWc15K9
	pCsy5WbX6mRBrTkmUrzOQhfv7QhNar7tH/tPaTK7x0S1s0wuNlf+2XxZbC31vOaD/p9zyqyt
	karKV08uUWIpzkg01GIuKk4EAKsJS9ZtAgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1586
Lines: 35

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, February 03, 2015 6:51 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 1/2] f2fs: keep PagePrivate during releasepage
> 
> If PagePrivate is removed by releasepage, f2fs loses counting dirty pages.
> 
> e.g., try_to_release_page will not release page when the page is dirty,
> but our releasepage removes PagePrivate.
> 
>     [<ffffffff81188d75>] try_to_release_page+0x35/0x50
>     [<ffffffff811996f9>] invalidate_inode_pages2_range+0x2f9/0x3b0
>     [<ffffffffa02a7f54>] ? truncate_blocks+0x384/0x4d0 [f2fs]
>     [<ffffffffa02b7583>] ? f2fs_direct_IO+0x283/0x290 [f2fs]
>     [<ffffffffa02b7fb0>] ? get_data_block_fiemap+0x20/0x20 [f2fs]
>     [<ffffffff8118aa53>] generic_file_direct_write+0x163/0x170
>     [<ffffffff8118ad06>] __generic_file_write_iter+0x2a6/0x350
>     [<ffffffff8118adef>] generic_file_write_iter+0x3f/0xb0
>     [<ffffffff81203081>] new_sync_write+0x81/0xb0
>     [<ffffffff81203837>] vfs_write+0xb7/0x1f0
>     [<ffffffff81204459>] SyS_write+0x49/0xb0
>     [<ffffffff817c286d>] system_call_fastpath+0x16/0x1b
> 
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>

Reviewed-by: Chao Yu <chao2.yu@samsung.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/