Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757194AbbBEJ5F (ORCPT ); Thu, 5 Feb 2015 04:57:05 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:57634 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756943AbbBEJ5B (ORCPT ); Thu, 5 Feb 2015 04:57:01 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-27-54d33dd8847f Message-id: <54D33E66.30909@samsung.com> Date: Thu, 05 Feb 2015 10:56:54 +0100 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-version: 1.0 To: Pankaj Dubey , Chanwoo Choi , mturquette@linaro.org Cc: tomasz.figa@gmail.com, kgene@kernel.org, inki.dae@samsung.com, chanho61.park@samsung.com, sw0312.kim@samsung.com, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [v3,1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain References: <1422922437-7414-2-git-send-email-cw00.choi@samsung.com> <54D31F67.1050701@samsung.com> In-reply-to: <54D31F67.1050701@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrALMWRmVeSWpSXmKPExsVy+t/xa7o3bC+HGPzexWVxeb+2xfUvz1kt 5h85x2ox6f4EFov+x6+ZLS7vmsNmMeP8PiaLpxMuslks2vqF3WLG5JdsFqt2/WF04PbYOesu u8emVZ1sHneu7WHz6NuyitHj8ya5ANYoLpuU1JzMstQifbsEroy13xexFhzhrvh64gZ7A+N8 zi5GTg4JAROJY4032SFsMYkL99azdTFycQgJLGWU+DvrOAuE84lRYvfauawgVbwCGhITp19j BLFZBFQl1n59xwRiswkYSvQe7QOLiwpESJy8u4cdol5Q4sfkeywgtohAlsTdyX8YQYYyC1xn lNi+9y1Ys7BAgMSkv2fAbCGBVImjJ7+ANXMKaEscmLkMaDEHUIOexP2LWiBhZgF5ic1r3jJP YBSYhWTFLISqWUiqFjAyr2IUTS1NLihOSs810itOzC0uzUvXS87P3cQIiYWvOxiXHrM6xCjA wajEw9vRezFEiDWxrLgy9xCjBAezkgivJsflECHelMTKqtSi/Pii0pzU4kOMTBycUg2MBr4e a0zX8qsqJpio1liuD/5YsrK9uarbW3UCw6rLyxWmt3A/SXr4gj31RsXbR+Wzv85fctrb+5P1 x4POXd92BRUZlwWfN06bfVlsYeCSC1fTTn8OVPmhLy505LbqL96QULmwnYer+blWtwq9Zdqe /Y9TpPOZiMHstHPvfxy7ld8uOs+A4z2LEktxRqKhFnNRcSIARq7IX2MCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1686 Lines: 40 On 05/02/15 08:44, Pankaj Dubey wrote: >> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = { >> > + >> > + /* ENABLE_PCLK_APOLLO */ >> > + GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo", >> > + "div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO, >> > + 2, CLK_IGNORE_UNUSED, 0), >> > + GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo", >> > + ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0), >> > + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo", > > Isn't "pclk_pmu_sysreg_apollo" be named as "pclk_sysreg_apollo" to match > with UM? Sounds reasonable, Chanwoo, if you agree I'll squash following change to this patch before sending upstream: diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 7a024cd..387e3e3 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -3656,7 +3656,7 @@ static struct samsung_gate_clock apollo_gate_clks[] __initdata = { 2, CLK_IGNORE_UNUSED, 0), GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo", ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0), - GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo", + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_sysreg_apollo", "div_pclk_apollo", ENABLE_PCLK_APOLLO, 0, CLK_IGNORE_UNUSED, 0), -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/