Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757259AbbBELZK (ORCPT ); Thu, 5 Feb 2015 06:25:10 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:49270 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757168AbbBELZH (ORCPT ); Thu, 5 Feb 2015 06:25:07 -0500 X-AuditID: cbfee68e-f79b46d000002b74-3f-54d35311b3c2 Message-id: <54D35332.6000309@samsung.com> Date: Thu, 05 Feb 2015 16:55:38 +0530 From: Pankaj Dubey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-version: 1.0 To: Krzysztof Kozlowski , Russell King , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Bartlomiej Zolnierkiewicz , Marek Szyprowski , cpgs@samsung.com Subject: Re: [PATCH v3 1/3] ARM: EXYNOS: Add missing static to file-scope declarations References: <1423121002-25117-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1423121002-25117-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsWyRsSkRlcw+HKIwfG/GhYbZ6xntXh5SNPi 9QtDi/7Hr5ktNj2+xmpxedccNosZ5/cxWdy+zGux9shddgdOj5bmHjaPTas62Tw2L6n36Nuy itHj8ya5ANYoLpuU1JzMstQifbsErozWDc1MBZvYKuZO/8TSwHiEtYuRk0NCwESiv+kjG4Qt JnHh3nogm4tDSGApo0THnl/sMEXTX71nh0hMZ5Q48u8hlNPKJLF38SRGkCpeAS2JG3//s4DY LAKqEn+/rwBbwSagK/Hk/VxmEFtUIELiw6qvbBD1ghI/Jt9jARkkIvCEUWLt2dtgCWaBSolZ 76+A2cJADf8ebmYCsYUE3CWmnF8FFucU8JD4e3chM0S9rcSC9+tYIGx5ic1r3jJDnH2NXWL1 ImWIgwQkvk0+BFTDARSXldh0AKpEUuLgihssExjFZiE5aRaSqbOQTF3AyLyKUTS1ILmgOCm9 yEivODG3uDQvXS85P3cTIzAKT/971reD8eYB60OMAhyMSjy8FvsuhQixJpYVV+YeYjQFumIi s5Rocj4w1vNK4g2NzYwsTE1MjY3MLc2UxHkTpH4GCwmkJ5akZqemFqQWxReV5qQWH2Jk4uCU amAs/PHikouDkzL7vI1p27POHxHqczyo9JfxZOFOhVSuQ5dVShcK9Co8VHB+6iu96PIrs/23 JmWe6Fh+3nWbe1y+ct/k5bet5x8MPL/1ozfjuU/PlvLa+qU8zMpR6VnK4/UqX91jmzL7n4fS v+xW/9Ot/Np5x7jg+9dqE56WELNJSgsEtzw++3OCEktxRqKhFnNRcSIABP/Jh70CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKIsWRmVeSWpSXmKPExsVy+t9jQV3B4MshBsc2y1tsnLGe1eLlIU2L 1y8MLfofv2a22PT4GqvF5V1z2CxmnN/HZHH7Mq/F2iN32R04PVqae9g8Nq3qZPPYvKTeo2/L KkaPz5vkAlijGhhtMlITU1KLFFLzkvNTMvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwC dN0yc4CuUVIoS8wpBQoFJBYXK+nbYZoQGuKmawHTGKHrGxIE12NkgAYS1jBmtG5oZirYxFYx d/onlgbGI6xdjJwcEgImEtNfvWeHsMUkLtxbz9bFyMUhJDCdUeLIv4fsEE4rk8TexZMYQap4 BbQkbvz9zwJiswioSvz9vgJsEpuArsST93OZQWxRgQiJD6u+skHUC0r8mHyPBWSQiMATRom1 Z2+DJZgFKiVmvb8CZgsDNfx7uJkJxBYScJeYcn4VWJxTwEPi792FzBD1thIL3q9jgbDlJTav ecs8gVFgFpIds5CUzUJStoCReRWjaGpBckFxUnqukV5xYm5xaV66XnJ+7iZGcJQ/k97BuKrB 4hCjAAejEg+vxb5LIUKsiWXFlbmHGCU4mJVEeLd4XQ4R4k1JrKxKLcqPLyrNSS0+xGgKDIKJ zFKiyfnABJRXEm9obGJuamxqaWJhYmapJM6rZN8WIiSQnliSmp2aWpBaBNPHxMEp1cC4LiEx RV+p8321IMfuFIuo50czW8wndArsC560IfmNuqW5NMu02aeqpte8c7KZP3mBf/rNx7295o/D Bdf5/EgwjUiccnbhuy8vlyqI8nY5nWZuZT538C3r5mw1pRMbg43CFrEI/3/4ykpItrvLuFnT vTJ5n5K7zWr3TbazNl5c63v0XvpmXUUlluKMREMt5qLiRACjPR7ICAMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1045 Lines: 23 Hi Krzysztof, On Thursday 05 February 2015 12:53 PM, Krzysztof Kozlowski wrote: > The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs' > and 'exynos5420_release_ret_regs' are not exported nor used outside of > suspend.c file. Make them static. > > This fixes following sparse warnings: > arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static? > arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static? > arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static? > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Pankaj Dubey Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/