Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757447AbbBELxf (ORCPT ); Thu, 5 Feb 2015 06:53:35 -0500 Received: from mail-bl2on0097.outbound.protection.outlook.com ([65.55.169.97]:5775 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757168AbbBELxd (ORCPT ); Thu, 5 Feb 2015 06:53:33 -0500 X-AuditID: ac160a69-f79956d000002b3c-ec-54d35651002a Message-ID: <54D3564F.8000207@sandisk.com> Date: Thu, 5 Feb 2015 12:38:55 +0100 From: Bart Van Assche User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Lad Prabhakar , "James E.J. Bottomley" , CC: Subject: Re: [PATCH] scsi: fix sparse warnings References: <1423129268-16220-1-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1423129268-16220-1-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrGLMWRmVeSWpSXmKPExsWyRoxnkW5g2OUQg76JShaXepewWlzeNYfN ovv6DjaLl/dXMDuweOycdZfd4+S8n2wenzfJBTBHcdmkpOZklqUW6dslcGWse/+TseAuU8Xx 5g6WBsY1TF2MnBwSAiYSXy5tZYGwxSQu3FvP1sXIxSEkcIJR4sWV28wQznZGiVcHHrHDdJy6 fxQqsZlRYuHeu8wgCV4BLYlnmy6CjWIRUJE4M3MLG4jNJmAk8e39TLC4qECYxPfNO6DqBSVO znwCFhcRaGSUaOkrB7GZBZQkTj6+BLZMWEBP4tvDC2C2kICXRNeUK2D1nALeEm/23GaEqDeQ OLJoDiuELS+x/e0csOMkBFaxSry7uJIZolld4uSS+UwTGEVmIdk9C0n/LCT9CxiZVzGK5Wbm FOempxYYGukVJ+alZBZn6yXn525iBMcGV+YOxhWTzA8xCnAwKvHwWuy7FCLEmlhWXJl7iFGC g1lJhHeL1+UQId6UxMqq1KL8+KLSnNTiQ4zSHCxK4ryC07P8hQTSE0tSs1NTC1KLYLJMHJxS DYyCJSJ2qhWP2GV/cxYv1N4Sf3xN7rOCvnUyp9qnp912e8/1dePxx3+4n4m75nhra278nKQa Nf39fIkV2qd3c3LMM5Exe//5hnrQ+sc7pJNEjtWezO46c/FPwbNXArkPFk4Qlr4oMmHJgjQl z7scq8sPem7OlHm1y4S3/qD959VKAn+2x03Z/rtbiaU4I9FQi7moOBEAX/ZC24kCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNJMWRmVeSWpSXmKPExsXCtZEjRTcw7HKIwYSNkhaXepewWlzeNYfN ovv6DjaLl/dXMDuweOycdZfd4+S8n2wenzfJBTBHcdmkpOZklqUW6dslcGWse/+TseAuU8Xx 5g6WBsY1TF2MnBwSAiYSp+4fZYawxSQu3FvP1sXIxSEksJFR4mvXSXaQBK+AlsSzTRdZQGwW AVWJOfvXgdlsAkYS397PBLNFBcIkvm/ewQxRLyhxcuYTsLiIQBOjxPpJ2iA2s4CCRNezaYwg trCAnsS3hxfA5gsJeEl0TbkCVs8p4C3xZs9tRoh6PYkd13+xQtjyEtvfzmGewMg/C8mKWUjK ZiEpW8DIvIpRLDczpzg3PbPA0EivODEvJbM4Wy85P3cTIzg4OaN2MF6faH6IkYmDU6qB0SdE 3Vs5ZAmrmeiCg4V7Z01QnMGVe8ipXjr/PrOn8aOfss94V9YdOnR//scjzyLdn2V0m6cxr914 67/RfsvIzboZHdcatj2NqchcoPJTVLNFKGWNYNbJ38U5/7Rv9nUcOJxmd/3vshwjZRcL25hC Sc3lc9fvdTgU4JPOqfvhXfOxk5Nlbn3cpcRSnJFoqMVcVJwIAKpgWLD+AQAA X-EOPAttributedMessage: 0 Authentication-Results: spf=pass (sender IP is 63.163.107.173) smtp.mailfrom=Bart.VanAssche@sandisk.com; parallels.com; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:63.163.107.173;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(479174004)(24454002)(33656002)(46102003)(59896002)(50466002)(64126003)(36756003)(65806001)(92566002)(2950100001)(54356999)(65816999)(62966003)(77156002)(86362001)(87266999)(50986999)(76176999)(87936001)(47776003)(83506001)(23746002)(77096005)(19580395003)(19580405001)(80316001);DIR:OUT;SFP:1101;SCL:1;SRVR:CO1PR02MB062;H:milsmgep12.sandisk.com;FPR:;SPF:Pass;MLV:sfv;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB062; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:CO1PR02MB062; X-Forefront-PRVS: 0478C23FE0 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:CO1PR02MB062; X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2015 11:38:57.6121 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.173] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR02MB062 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 588 Lines: 11 On 02/05/15 10:41, Lad Prabhakar wrote: > this patch fixes following sparse warnings: > scsi_sysfs.c:201:25: warning: symbol 'dev_attr_hstate' was not declared. Should it be static? > scsi_sysfs.c:376:24: warning: symbol 'scsi_shost_attr_group' was not declared. Should it be static? Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/