Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757306AbbBEL4D (ORCPT ); Thu, 5 Feb 2015 06:56:03 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:59768 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752699AbbBEL4A convert rfc822-to-8bit (ORCPT ); Thu, 5 Feb 2015 06:56:00 -0500 MIME-Version: 1.0 In-Reply-To: <3110055.vYzQi51GtK@avalon> References: <1421365163-29394-1-git-send-email-prabhakar.csengg@gmail.com> <2517945.eGhlRo2yDj@avalon> <3110055.vYzQi51GtK@avalon> From: "Lad, Prabhakar" Date: Thu, 5 Feb 2015 11:55:28 +0000 Message-ID: Subject: Re: [PATCH] media: i2c: add support for omnivision's ov2659 sensor To: Laurent Pinchart Cc: LMML , "devicetree@vger.kernel.org" , LKML , Mauro Carvalho Chehab , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Grant Likely , Sakari Ailus , Hans Verkuil Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4054 Lines: 104 Hi Laurent, On Thu, Feb 5, 2015 at 11:53 AM, Laurent Pinchart wrote: > Hi Prabhakar, > > On Wednesday 04 February 2015 20:55:02 Lad, Prabhakar wrote: >> On Wed, Feb 4, 2015 at 5:03 PM, Laurent Pinchart wrote: >> > On Thursday 15 January 2015 23:39:23 Lad, Prabhakar wrote: >> >> From: Benoit Parrot >> >> >> >> this patch adds support for omnivision's ov2659 >> >> sensor. >> >> >> >> Signed-off-by: Benoit Parrot >> >> Signed-off-by: Lad, Prabhakar >> >> --- >> >> >> >> .../devicetree/bindings/media/i2c/ov2659.txt | 33 + >> >> .../devicetree/bindings/vendor-prefixes.txt | 1 + >> >> MAINTAINERS | 10 + >> >> drivers/media/i2c/Kconfig | 11 + >> >> drivers/media/i2c/Makefile | 1 + >> >> drivers/media/i2c/ov2659.c | 1623 >> >> +++++++++++++++++ >> >> include/media/ov2659.h | 33 + >> >> 7 files changed, 1712 insertions(+) >> >> create mode 100644 >> >> Documentation/devicetree/bindings/media/i2c/ov2659.txt >> >> create mode 100644 drivers/media/i2c/ov2659.c >> >> create mode 100644 include/media/ov2659.h > > [snip] > >> >> diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c >> >> new file mode 100644 >> >> index 0000000..ce8ec8d >> >> --- /dev/null >> >> +++ b/drivers/media/i2c/ov2659.c >> >> @@ -0,0 +1,1623 @@ > > [snip] > >> >> +static const struct ov2659_framesize ov2659_framesizes[] = { >> >> + { /* QVGA */ >> >> + .width = 320, >> >> + .height = 240, >> >> + .regs = ov2659_qvga, >> >> + .max_exp_lines = 248, >> >> + }, { /* VGA */ >> >> + .width = 640, >> >> + .height = 480, >> >> + .regs = ov2659_vga, >> >> + .max_exp_lines = 498, >> >> + }, { /* SVGA */ >> >> + .width = 800, >> >> + .height = 600, >> >> + .regs = ov2659_svga, >> >> + .max_exp_lines = 498, >> >> + }, { /* XGA */ >> >> + .width = 1024, >> >> + .height = 768, >> >> + .regs = ov2659_xga, >> >> + .max_exp_lines = 498, >> >> + }, { /* 720P */ >> >> + .width = 1280, >> >> + .height = 720, >> >> + .regs = ov2659_720p, >> >> + .max_exp_lines = 498, >> >> + }, { /* SXGA */ >> >> + .width = 1280, >> >> + .height = 1024, >> >> + .regs = ov2659_sxga, >> >> + .max_exp_lines = 1048, >> >> + }, { /* UXGA */ >> >> + .width = 1600, >> >> + .height = 1200, >> >> + .regs = ov2659_uxga, >> >> + .max_exp_lines = 498, >> >> + }, >> >> +}; >> > >> > That's what bothers me the most about drivers for Omnivision sensors. For >> > some reason (I'd bet on lack of proper documentation) they list a couple >> > of supported resolutions with corresponding register values, instead of >> > computing the register values from the format configured by userspace. >> > That's not the way we want to go. Prabhakar, do you have enough >> > documentation to fix that ? >> >> I am afraid I have limited documentation here. > > How limited ? :-) I assume someone has documentation, given that the patch > contains a larger number of #define's with register names. > Yea I don’t have NDA signed with TI/Omnivision :( because I which I lack the documentation. Regards, --Prabhakar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/