Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757506AbbBEMDu (ORCPT ); Thu, 5 Feb 2015 07:03:50 -0500 Received: from mail-wg0-f41.google.com ([74.125.82.41]:53492 "EHLO mail-wg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756786AbbBEMDs (ORCPT ); Thu, 5 Feb 2015 07:03:48 -0500 From: Lad Prabhakar To: "James E.J. Bottomley" , linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: [PATCH] scsi: initio: fix sparse warnings Date: Thu, 5 Feb 2015 12:03:33 +0000 Message-Id: <1423137813-25709-1-git-send-email-prabhakar.csengg@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5107 Lines: 136 From: "Lad, Prabhakar" this patch fixes following sparse warnings: initio.c:338:6: warning: symbol 'initio_se2_ew_en' was not declared. Should it be static? initio.c:352:6: warning: symbol 'initio_se2_ew_ds' was not declared. Should it be static? initio.c:897:22: warning: symbol 'initio_find_busy_scb' was not declared. Should it be static? initio.c:935:22: warning: symbol 'initio_find_done_scb' was not declared. Should it be static? initio.c:1673:5: warning: symbol 'initio_state_7' was not declared. Should it be static? initio.c:1759:5: warning: symbol 'initio_xpad_in' was not declared. Should it be static? initio.c:1783:5: warning: symbol 'initio_xpad_out' was not declared. Should it be static? initio.c:1808:5: warning: symbol 'initio_status_msg' was not declared. Should it be static? initio.c:1858:5: warning: symbol 'int_initio_busfree' was not declared. Should it be static? initio.c:1928:5: warning: symbol 'int_initio_resel' was not declared. Should it be static? initio.c:2384:5: warning: symbol 'initio_bus_device_reset' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next. drivers/scsi/initio.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/initio.c b/drivers/scsi/initio.c index e5dae7b..49db7b7 100644 --- a/drivers/scsi/initio.c +++ b/drivers/scsi/initio.c @@ -335,7 +335,7 @@ static void initio_se2_instr(unsigned long base, u8 instr) * * Enable erase/write state of serial EEPROM */ -void initio_se2_ew_en(unsigned long base) +static void initio_se2_ew_en(unsigned long base) { initio_se2_instr(base, 0x30); /* EWEN */ outb(0, base + TUL_NVRAM); /* -CS */ @@ -349,7 +349,7 @@ void initio_se2_ew_en(unsigned long base) * * Disable erase/write state of serial EEPROM */ -void initio_se2_ew_ds(unsigned long base) +static void initio_se2_ew_ds(unsigned long base) { initio_se2_instr(base, 0); /* EWDS */ outb(0, base + TUL_NVRAM); /* -CS */ @@ -894,7 +894,8 @@ static void initio_unlink_busy_scb(struct initio_host * host, struct scsi_ctrl_b return; } -struct scsi_ctrl_blk *initio_find_busy_scb(struct initio_host * host, u16 tarlun) +static struct scsi_ctrl_blk * +initio_find_busy_scb(struct initio_host *host, u16 tarlun) { struct scsi_ctrl_blk *tmp, *prev; u16 scbp_tarlun; @@ -932,7 +933,7 @@ static void initio_append_done_scb(struct initio_host * host, struct scsi_ctrl_b } } -struct scsi_ctrl_blk *initio_find_done_scb(struct initio_host * host) +static struct scsi_ctrl_blk *initio_find_done_scb(struct initio_host *host) { struct scsi_ctrl_blk *tmp; @@ -1670,7 +1671,7 @@ static int initio_state_6(struct initio_host * host) * */ -int initio_state_7(struct initio_host * host) +static int initio_state_7(struct initio_host *host) { int cnt, i; @@ -1756,7 +1757,7 @@ static int initio_xfer_data_out(struct initio_host * host) return 0; /* return to OS, wait xfer done , let jas_isr come in */ } -int initio_xpad_in(struct initio_host * host) +static int initio_xpad_in(struct initio_host *host) { struct scsi_ctrl_blk *scb = host->active; struct target_control *active_tc = host->active_tc; @@ -1780,7 +1781,7 @@ int initio_xpad_in(struct initio_host * host) } } -int initio_xpad_out(struct initio_host * host) +static int initio_xpad_out(struct initio_host *host) { struct scsi_ctrl_blk *scb = host->active; struct target_control *active_tc = host->active_tc; @@ -1805,7 +1806,7 @@ int initio_xpad_out(struct initio_host * host) } } -int initio_status_msg(struct initio_host * host) +static int initio_status_msg(struct initio_host *host) { /* status & MSG_IN */ struct scsi_ctrl_blk *scb = host->active; u8 msg; @@ -1855,7 +1856,7 @@ int initio_status_msg(struct initio_host * host) /* scsi bus free */ -int int_initio_busfree(struct initio_host * host) +static int int_initio_busfree(struct initio_host *host) { struct scsi_ctrl_blk *scb = host->active; @@ -1925,7 +1926,7 @@ static int int_initio_scsi_rst(struct initio_host * host) * and continue processing that command. */ -int int_initio_resel(struct initio_host * host) +static int int_initio_resel(struct initio_host *host) { struct scsi_ctrl_blk *scb; struct target_control *active_tc; @@ -2381,7 +2382,7 @@ static void initio_select_atn3(struct initio_host * host, struct scsi_ctrl_blk * * Perform a device reset and abort all pending SCBs for the * victim device */ -int initio_bus_device_reset(struct initio_host * host) +static int initio_bus_device_reset(struct initio_host *host) { struct scsi_ctrl_blk *scb = host->active; struct target_control *active_tc = host->active_tc; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/