Date: Thu, 5 Feb 2015 15:51:24 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
        Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        Chaitanya Hazarey <c@24.io>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
        linux-kernel@vger.kernel.org, Greg Donald <gdonald@gmail.com>,
        Koray Gulcu <koray.gulcu@ozu.edu.tr>
Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null
 pointer dereference
Message-ID: <20150205125124.GG5336@mwanda>
References: <1422557952-4209-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
 <20150205122745.GF5336@mwanda>
 <20150205124322.GA8137@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150205124322.GA8137@sudip-PC>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 625
Lines: 18

On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote:
> if (driver_info) {
> 	stats->RxIs40MHzPacket = driver_info->BW;
> 	if (stats->RxDrvInfoSize != 0)
> 		TranslateRxSignalStuff819xUsb(skb, stats, driver_info);
> }

If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and
also the reverse.  So really you only need to test one.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/