Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757669AbbBENmk (ORCPT ); Thu, 5 Feb 2015 08:42:40 -0500 Received: from mail-ig0-f172.google.com ([209.85.213.172]:59949 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753494AbbBENmh (ORCPT ); Thu, 5 Feb 2015 08:42:37 -0500 MIME-Version: 1.0 Reply-To: cw00.choi@samsung.com In-Reply-To: <54D33E66.30909@samsung.com> References: <1422922437-7414-2-git-send-email-cw00.choi@samsung.com> <54D31F67.1050701@samsung.com> <54D33E66.30909@samsung.com> Date: Thu, 5 Feb 2015 22:42:36 +0900 Message-ID: Subject: Re: [v3,1/9] clk: samsung: exynos5433: Add clocks for CMU_APOLLO domain From: Chanwoo Choi To: Sylwester Nawrocki Cc: Pankaj Dubey , Mike Turquette , Tomasz Figa , Kukjin Kim , "inki.dae@samsung.com" , "chanho61.park@samsung.com" , Seung-Woo Kim , linux-samsung-soc , linux-kernel , devicetree Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1943 Lines: 49 Hi Pankaj and Sylwester, On Thu, Feb 5, 2015 at 6:56 PM, Sylwester Nawrocki wrote: > On 05/02/15 08:44, Pankaj Dubey wrote: >>> +static struct samsung_gate_clock apollo_gate_clks[] __initdata = { > >>> > + >>> > + /* ENABLE_PCLK_APOLLO */ >>> > + GATE(CLK_PCLK_ASAPBMST_CSSYS_APOLLO, "pclk_asapbmst_cssys_apollo", >>> > + "div_pclk_dbg_apollo", ENABLE_PCLK_APOLLO, >>> > + 2, CLK_IGNORE_UNUSED, 0), >>> > + GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo", >>> > + ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0), >>> > + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo", >> >> Isn't "pclk_pmu_sysreg_apollo" be named as "pclk_sysreg_apollo" to match >> with UM? You're right. It is my mistake. > > Sounds reasonable, Chanwoo, if you agree I'll squash following change > to this patch before sending upstream: I agree. > > diff --git a/drivers/clk/samsung/clk-exynos5433.c > b/drivers/clk/samsung/clk-exynos5433.c > index 7a024cd..387e3e3 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -3656,7 +3656,7 @@ static struct samsung_gate_clock apollo_gate_clks[] > __initdata = { > 2, CLK_IGNORE_UNUSED, 0), > GATE(CLK_PCLK_PMU_APOLLO, "pclk_pmu_apollo", "div_pclk_apollo", > ENABLE_PCLK_APOLLO, 1, CLK_IGNORE_UNUSED, 0), > - GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_pmu_sysreg_apollo", > + GATE(CLK_PCLK_SYSREG_APOLLO, "pclk_sysreg_apollo", > "div_pclk_apollo", ENABLE_PCLK_APOLLO, > 0, CLK_IGNORE_UNUSED, 0), Best Regards, Chanwoo Choi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/