Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbbBEPFk (ORCPT ); Thu, 5 Feb 2015 10:05:40 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:58611 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbbBEPFj (ORCPT ); Thu, 5 Feb 2015 10:05:39 -0500 From: Laurent Pinchart To: Lad Prabhakar Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: function/uvc_v4l2.c: fix sparse warnings Date: Thu, 05 Feb 2015 17:06:22 +0200 Message-ID: <2766164.9ZDvr0n94s@avalon> User-Agent: KMail/4.14.3 (Linux/3.17.7-gentoo; KDE/4.14.3; x86_64; ; ) In-Reply-To: <1423142186-24131-1-git-send-email-prabhakar.csengg@gmail.com> References: <1423142186-24131-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1389 Lines: 46 Hi Prabhakar, Thank you for the patch. On Thursday 05 February 2015 13:16:26 Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warnings: > > uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared. > Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was > not declared. Should it be static? > > Signed-off-by: Lad, Prabhakar Acked-by: Laurent Pinchart Felipe, could you please take this in your tree ? > --- > drivers/usb/gadget/function/uvc_v4l2.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/function/uvc_v4l2.c > b/drivers/usb/gadget/function/uvc_v4l2.c index 5aad7fe..8b818fd 100644 > --- a/drivers/usb/gadget/function/uvc_v4l2.c > +++ b/drivers/usb/gadget/function/uvc_v4l2.c > @@ -27,6 +27,7 @@ > #include "uvc.h" > #include "uvc_queue.h" > #include "uvc_video.h" > +#include "uvc_v4l2.h" > > /* ------------------------------------------------------------------------- > * Requests handling -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/