Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757837AbbBEPhG (ORCPT ); Thu, 5 Feb 2015 10:37:06 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56916 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753596AbbBEPhE (ORCPT ); Thu, 5 Feb 2015 10:37:04 -0500 Date: Thu, 5 Feb 2015 16:36:58 +0100 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 1/1 linux-next] udf: use bool for done Message-ID: <20150205153658.GI4258@quack.suse.cz> References: <1423070104-7308-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423070104-7308-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 45 On Wed 04-02-15 18:15:04, Fabian Frederick wrote: > variable 'done' is only used for true/false in loop. OK, looks good. Merged. Honza > > Signed-off-by: Fabian Frederick > --- > fs/udf/super.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/udf/super.c b/fs/udf/super.c > index 3d35a75..f169411 100644 > --- a/fs/udf/super.c > +++ b/fs/udf/super.c > @@ -1599,7 +1599,7 @@ static noinline int udf_process_sequence( > struct udf_vds_record *curr; > struct generic_desc *gd; > struct volDescPtr *vdp; > - int done = 0; > + bool done = false; > uint32_t vdsn; > uint16_t ident; > long next_s = 0, next_e = 0; > @@ -1680,7 +1680,7 @@ static noinline int udf_process_sequence( > lastblock = next_e; > next_s = next_e = 0; > } else > - done = 1; > + done = true; > break; > } > brelse(bh); > -- > 1.9.3 > -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/