Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758124AbbBEPiC (ORCPT ); Thu, 5 Feb 2015 10:38:02 -0500 Received: from down.free-electrons.com ([37.187.137.238]:36047 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757788AbbBEPiA (ORCPT ); Thu, 5 Feb 2015 10:38:00 -0500 Date: Thu, 5 Feb 2015 16:37:56 +0100 From: Boris Brezillon To: Daniel Vetter Cc: David Airlie , dri-devel@lists.freedesktop.org, Nicolas Ferre , Jean-Christophe Plagniol-Villard , Alexandre Belloni , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drm: atmel-hlcdc: Atomic mode-setting conversion Message-ID: <20150205163756.74a1bde0@bbrezillon> In-Reply-To: <20150205130832.GU14009@phenom.ffwll.local> References: <1423081251-11062-1-git-send-email-boris.brezillon@free-electrons.com> <20150205130832.GU14009@phenom.ffwll.local> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 34 On Thu, 5 Feb 2015 14:08:32 +0100 Daniel Vetter wrote: > On Wed, Feb 04, 2015 at 09:20:51PM +0100, Boris Brezillon wrote: > > Convert the HLCDC driver to atomic mode-setting. > > > > Signed-off-by: Boris Brezillon > > Just a quick comment: dpms isn't yet converted over, and from experience > with tegra/msm that probably will yield some surprises. Since only with > dpms will it be obvious how strict the added requirements from the atomic > helpers are ;-) Yes, I noticed I was not using the appropriate dpms helper in the connector funcs just after sending this patch. Would this patch [1] address what you're talking about, or am I still missing something ? Thanks, Boris [1]http://code.bulix.org/l70xf4-87827 -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/