Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758204AbbBEQHI (ORCPT ); Thu, 5 Feb 2015 11:07:08 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:63972 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757786AbbBEQHH (ORCPT ); Thu, 5 Feb 2015 11:07:07 -0500 Message-ID: <54D3951C.1080200@atmel.com> Date: Thu, 5 Feb 2015 17:06:52 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Lad Prabhakar , CC: Subject: Re: [PATCH] net/macb: fix sparse warning References: <1423150846-7027-1-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1423150846-7027-1-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1469 Lines: 45 Le 05/02/2015 16:40, Lad Prabhakar a ?crit : > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? Well, actually this function doesn't need to be exported and indeed should be marked as static. I'm not against this patch, but removing the export macro and making it as static should do the trick even better. Bye, > Signed-off-by: Lad, Prabhakar > --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/net/ethernet/cadence/macb.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/ethernet/cadence/macb.h b/drivers/net/ethernet/cadence/macb.h > index 31dc080..e6ad68a 100644 > --- a/drivers/net/ethernet/cadence/macb.h > +++ b/drivers/net/ethernet/cadence/macb.h > @@ -821,6 +821,7 @@ struct macb { > }; > > extern const struct ethtool_ops macb_ethtool_ops; > +extern const struct ethtool_ops gem_ethtool_ops; > > int macb_mii_init(struct macb *bp); > int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd); > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/