Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757937AbbBEQXN (ORCPT ); Thu, 5 Feb 2015 11:23:13 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:39058 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757842AbbBEQXM convert rfc822-to-8bit (ORCPT ); Thu, 5 Feb 2015 11:23:12 -0500 MIME-Version: 1.0 In-Reply-To: <54D3951C.1080200@atmel.com> References: <1423150846-7027-1-git-send-email-prabhakar.csengg@gmail.com> <54D3951C.1080200@atmel.com> From: "Lad, Prabhakar" Date: Thu, 5 Feb 2015 16:22:39 +0000 Message-ID: Subject: Re: [PATCH] net/macb: fix sparse warning To: Nicolas Ferre Cc: netdev , LKML Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 876 Lines: 25 On Thu, Feb 5, 2015 at 4:06 PM, Nicolas Ferre wrote: > Le 05/02/2015 16:40, Lad Prabhakar a écrit : >> From: "Lad, Prabhakar" >> >> this patch fixes following sparse warning: >> >> macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? > > Well, actually this function doesn't need to be exported and indeed > should be marked as static. > > I'm not against this patch, but removing the export macro and making it > as static should do the trick even better. > Done! [1] https://patchwork.kernel.org/patch/5785511/ Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/