Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758087AbbBEQkT (ORCPT ); Thu, 5 Feb 2015 11:40:19 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:2812 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbbBEQkR (ORCPT ); Thu, 5 Feb 2015 11:40:17 -0500 Message-ID: <54D39CEC.5040200@atmel.com> Date: Thu, 5 Feb 2015 17:40:12 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Lad Prabhakar , , "Eric Dumazet" CC: Subject: Re: [PATCH v2] net/macb: fix sparse warning References: <1423153267-1768-1-git-send-email-prabhakar.csengg@gmail.com> In-Reply-To: <1423153267-1768-1-git-send-email-prabhakar.csengg@gmail.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1786 Lines: 54 Le 05/02/2015 17:21, Lad Prabhakar a ?crit : > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > macb.c:2038:26: warning: symbol 'gem_ethtool_ops' was not declared. Should it be static? > > Alongside drops exporting of gem_ethtool_ops as there is no need. > > Signed-off-by: Lad, Prabhakar Okay with this one: Acked-by: Nicolas Ferre Thanks! Bye, > --- > Found this issue on linux-next (gcc version 4.8.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/net/ethernet/cadence/macb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c > index 4f7bd13..ad76b8e 100644 > --- a/drivers/net/ethernet/cadence/macb.c > +++ b/drivers/net/ethernet/cadence/macb.c > @@ -2035,7 +2035,7 @@ const struct ethtool_ops macb_ethtool_ops = { > }; > EXPORT_SYMBOL_GPL(macb_ethtool_ops); > > -const struct ethtool_ops gem_ethtool_ops = { > +static const struct ethtool_ops gem_ethtool_ops = { > .get_settings = macb_get_settings, > .set_settings = macb_set_settings, > .get_regs_len = macb_get_regs_len, > @@ -2046,7 +2046,6 @@ const struct ethtool_ops gem_ethtool_ops = { > .get_strings = gem_get_ethtool_strings, > .get_sset_count = gem_get_sset_count, > }; > -EXPORT_SYMBOL_GPL(gem_ethtool_ops); > > int macb_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) > { > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/