Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758495AbbBERjR (ORCPT ); Thu, 5 Feb 2015 12:39:17 -0500 Received: from mail-ig0-f182.google.com ([209.85.213.182]:41872 "EHLO mail-ig0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758357AbbBERjP (ORCPT ); Thu, 5 Feb 2015 12:39:15 -0500 MIME-Version: 1.0 In-Reply-To: <20150205125124.GG5336@mwanda> References: <1422557952-4209-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150205122745.GF5336@mwanda> <20150205124322.GA8137@sudip-PC> <20150205125124.GG5336@mwanda> Date: Thu, 5 Feb 2015 18:39:13 +0100 Message-ID: Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference From: Rickard Strandqvist To: Dan Carpenter Cc: Sudip Mukherjee , "devel@driverdev.osuosl.org" , Chaitanya Hazarey , Greg Kroah-Hartman , Peter P Waskiewicz Jr , Linux Kernel Mailing List , Greg Donald , Koray Gulcu Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 890 Lines: 27 2015-02-05 13:51 GMT+01:00 Dan Carpenter : > On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote: >> if (driver_info) { >> stats->RxIs40MHzPacket = driver_info->BW; >> if (stats->RxDrvInfoSize != 0) >> TranslateRxSignalStuff819xUsb(skb, stats, driver_info); >> } > > If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and > also the reverse. So really you only need to test one. > > regards, > dan carpenter > True Dan Okay, I'll make one last patch then, or if you want to do it Sudip? Have you not done before Saturday I do it. Kind regards Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/