Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752992AbbBESDq (ORCPT ); Thu, 5 Feb 2015 13:03:46 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:33711 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbbBESDp (ORCPT ); Thu, 5 Feb 2015 13:03:45 -0500 Date: Thu, 5 Feb 2015 10:03:44 -0800 From: Greg Kroah-Hartman To: Joe Perches Cc: Al Viro , Andreas Ruprecht , Oleg Drokin , Andreas Dilger , HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Lad, Prabhakar" Subject: Re: use of opaque subject lines Message-ID: <20150205180344.GA8971@kroah.com> References: <1422884203-27173-1-git-send-email-rupran@einserver.de> <20150202141606.GY29656@ZenIV.linux.org.uk> <54CFCC46.40909@einserver.de> <20150205163053.GQ29656@ZenIV.linux.org.uk> <1423156139.4752.1.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423156139.4752.1.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1757 Lines: 47 On Thu, Feb 05, 2015 at 09:08:59AM -0800, Joe Perches wrote: > On Thu, 2015-02-05 at 16:30 +0000, Al Viro wrote: > > On Mon, Feb 02, 2015 at 08:13:10PM +0100, Andreas Ruprecht wrote: > > > > > On a serious note: I do understand what you're getting at, I don't take > > > that personally (and I will send a v2 addressing the things above), but > > > honestly, this kind of answer might just be a real turn-off for other > > > people trying to get into kernel development... > > > > > > I don't want to start a whole new 'attitude in the kernel community' > > > discussion, but I can't just let this go like that, sorry. > > Maybe YA checkpatch warning when patch subjects > include either "checkpatch" or "sparse" would help? > > Something like: > --- > scripts/checkpatch.pl | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 3642b0d..b6bed59 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2170,6 +2170,13 @@ sub process { > } > } > > +# Check email subject for poor style > + if ($in_header_lines && > + $line =~ /^Subject:.*\b(?:checkpatch|sparse)\b[^:]/i) { > + WARN("EMAIL_SUBJECT", > + "A patch subject line should describe the change not the tool that found it\n" . $herecurr); > + } > + > # Check for old stable address > if ($line =~ /^\s*cc:\s*.*?.*$/i) { > ERROR("STABLE_ADDRESS", > Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/