Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754120AbbBESEs (ORCPT ); Thu, 5 Feb 2015 13:04:48 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:32998 "EHLO mail-lb0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbbBESEm (ORCPT ); Thu, 5 Feb 2015 13:04:42 -0500 Message-ID: <54D3B0B6.80201@cogentembedded.com> Date: Thu, 05 Feb 2015 21:04:38 +0300 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Romain Perier , johnyoun@synopsys.com CC: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] usb: dwc2: Register interrupt handler only once gadget is correctly initialized References: <1423158439-1639-1-git-send-email-romain.perier@gmail.com> In-Reply-To: <1423158439-1639-1-git-send-email-romain.perier@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 28 Hello. On 02/05/2015 08:47 PM, Romain Perier wrote: > Don't register interrupt handler becore usb gadget is correctly initialized. s/becore/before/? > For some embedded platforms which don't have a usb-phy it crashes the driver > because an interrupt is emitted with non-initiliazed hardware. s/non-initiliazed/non-initialized/. > According to devm_request_irq documentation, an interrupt can be emitted > at any time once the interrupt is registered, so we have to care about driver > and hardware initialization. > Signed-off-by: Romain Perier [...] WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/