Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752478AbbBETXJ (ORCPT ); Thu, 5 Feb 2015 14:23:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55444 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbbBETXH (ORCPT ); Thu, 5 Feb 2015 14:23:07 -0500 Message-ID: <54D3C314.3070903@redhat.com> Date: Thu, 05 Feb 2015 14:23:00 -0500 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Paolo Bonzini , Jan Kiszka , linux-kernel@vger.kernel.org, kvm@vger.kernel.org CC: rkrcmar@redhat.com, mtosatti@redhat.com Subject: Re: [PATCH RFC] kvm: x86: add halt_poll module parameter References: <1423152325-5094-1-git-send-email-pbonzini@redhat.com> <54D3BC94.9010007@siemens.com> <54D3C296.7030207@redhat.com> In-Reply-To: <54D3C296.7030207@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1209 Lines: 34 On 02/05/2015 02:20 PM, Paolo Bonzini wrote: > > > On 05/02/2015 19:55, Jan Kiszka wrote: >>> This patch introduces a new module parameter for the KVM module; when it >>> is present, KVM attempts a bit of polling on every HLT before scheduling >>> itself out via kvm_vcpu_block. >> >> Wouldn't it be better to tune this on a per-VM basis? Think of mixed >> workloads with some latency-sensitive and some standard VMs. > > Yes, but: > > 1) this turned out to be very cheap, so a per-host tunable is not too bad; > > 2) it also affects only very few workloads (for example network > workloads can already do polling in the guest) so it only affects few > people; > > 3) long term anyway we want it to auto tune, which is better than tuning > it per-VM. We may want to auto tune it per VM. However, if we make auto tuning work well, I do not think we want to expose a user visible tunable per VM, and commit to keeping that kind of interface around forever. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/