Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754128AbbBETbR (ORCPT ); Thu, 5 Feb 2015 14:31:17 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:47772 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753383AbbBETbP (ORCPT ); Thu, 5 Feb 2015 14:31:15 -0500 Date: Thu, 5 Feb 2015 14:31:04 -0500 From: Konrad Rzeszutek Wilk To: Lad Prabhakar Cc: Boris Ostrovsky , David Vrabel , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] xen/acpi-processor: fix sparse warning Message-ID: <20150205193104.GB11646@x230.dumpdata.com> References: <1423136361-11338-1-git-send-email-prabhakar.csengg@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1423136361-11338-1-git-send-email-prabhakar.csengg@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1542 Lines: 43 On Thu, Feb 05, 2015 at 11:39:21AM +0000, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > xen-acpi-processor.c:505:23: warning: symbol 'xen_acpi_processor_resume_nb' was not declared. Should it be static? Not sure if it is worth fixing it - as that whole code is only executed under normal PV guests - where it does not make sense for it be executed. That whole xen_resume_notifier should go away. > > Signed-off-by: Lad, Prabhakar > --- > Found this issue on linux-next (gcc version 4.9.2, > sparse version 0.4.5-rc1)and applies on top linux-next. > > drivers/xen/xen-acpi-processor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/xen/xen-acpi-processor.c b/drivers/xen/xen-acpi-processor.c > index 59fc190..6c1f921 100644 > --- a/drivers/xen/xen-acpi-processor.c > +++ b/drivers/xen/xen-acpi-processor.c > @@ -502,7 +502,7 @@ static int xen_acpi_processor_resume(struct notifier_block *nb, > return xen_upload_processor_pm_data(); > } > > -struct notifier_block xen_acpi_processor_resume_nb = { > +static struct notifier_block xen_acpi_processor_resume_nb = { > .notifier_call = xen_acpi_processor_resume, > }; > > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/