Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbbBEUOn (ORCPT ); Thu, 5 Feb 2015 15:14:43 -0500 Received: from mail-wi0-f182.google.com ([209.85.212.182]:56356 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbBEUOm (ORCPT ); Thu, 5 Feb 2015 15:14:42 -0500 Message-ID: <54D3CF2C.6030203@redhat.com> Date: Thu, 05 Feb 2015 21:14:36 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Rik van Riel , Jan Kiszka , linux-kernel@vger.kernel.org, kvm@vger.kernel.org CC: rkrcmar@redhat.com, mtosatti@redhat.com Subject: Re: [PATCH RFC] kvm: x86: add halt_poll module parameter References: <1423152325-5094-1-git-send-email-pbonzini@redhat.com> <54D3BC94.9010007@siemens.com> <54D3C296.7030207@redhat.com> <54D3C314.3070903@redhat.com> In-Reply-To: <54D3C314.3070903@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 908 Lines: 25 On 05/02/2015 20:23, Rik van Riel wrote: >> > 3) long term anyway we want it to auto tune, which is better than tuning >> > it per-VM. > We may want to auto tune it per VM. We may even want to auto tune it per VCPU. > However, if we make auto tuning work well, I do not > think we want to expose a user visible tunable per > VM, and commit to keeping that kind of interface > around forever. Exactly. We probably want module parameters to tune the minimum/maximum values (which includes the special cases of disabling polling altogether, and disabling the autotuning while leaving polling enabled), but committing to a per-VM interface is premature. Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/