MIME-Version: 1.0
In-Reply-To: <20150205193412.24669.8648.stgit@localhost.localdomain>
References: <20150205193412.24669.8648.stgit@localhost.localdomain>
Date: Thu, 5 Feb 2015 13:28:22 -0800
Message-ID: <CAGXu5jK-dRTBDkF_cfVuuQRXH80r2-TVTgPZ1fDqYoVMABfaHw@mail.gmail.com>
Subject: Re: [PATCH v5 0/4] powerpc/pstore: Add pstore support for nvram partitions
From: Kees Cook <keescook@chromium.org>
To: Hari Bathini <hbathini@linux.vnet.ibm.com>
Cc: Tony Luck <tony.luck@intel.com>, Anton Vorontsov <anton@enomsg.org>,
        lkml <linux-kernel@vger.kernel.org>,
        linuxppc-dev <linuxppc-dev@ozlabs.org>,
        Colin Cross <ccross@android.com>,
        Mahesh J Salgaonkar <mahesh@linux.vnet.ibm.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1804
Lines: 53

On Thu, Feb 5, 2015 at 11:35 AM, Hari Bathini
<hbathini@linux.vnet.ibm.com> wrote:
> This patch series adds pstore support on powernv platform to
> read different nvram partitions and write compressed data to
> oops-log nvram partition. As pseries platform already has
> pstore support, this series moves most of the common code
> for pseries and powernv platforms to a common file. Tested
> the patches successfully on both pseries and powernv
> platforms. Also, tested the patches successfully, on a kernel
> compiled with both CONFIG_PPC_PSERIES=y & CONFIG_PPC_POWERNV=y.
>
> Changes from v4:
> 1. Added a patch for y2038-safe code changes
>
> ---
>
> Hari Bathini (4):
>       powerpc/nvram: move generic code for nvram and pstore
>       pstore: Add pstore type id for PPC64 opal nvram partition
>       pstore: add pstore support on powernv
>       powerpc: make timestamp related code y2038-safe

Thanks! I skimmed this, and it looks good to me.

Reviewed-by: Kees Cook <keescook@chromium.org>

-Kees

>
>
>  arch/powerpc/include/asm/nvram.h            |   50 ++
>  arch/powerpc/include/asm/rtas.h             |    5
>  arch/powerpc/kernel/nvram_64.c              |  677 +++++++++++++++++++++++++++
>  arch/powerpc/platforms/powernv/opal-nvram.c |   10
>  arch/powerpc/platforms/pseries/nvram.c      |  673 ---------------------------
>  fs/pstore/inode.c                           |    3
>  include/linux/pstore.h                      |    1
>  7 files changed, 754 insertions(+), 665 deletions(-)
>
> --
> -Hari
>


-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/