Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbbBFABS (ORCPT ); Thu, 5 Feb 2015 19:01:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752669AbbBFABR (ORCPT ); Thu, 5 Feb 2015 19:01:17 -0500 Message-ID: <1423180863.3299.1.camel@pluto.fritz.box> Subject: Re: [RFC PATCH 2/8] kmod - rename call_usermodehelper() flags parameter From: Ian Kent To: David Howells Cc: Kernel Mailing List , Oleg Nesterov , Trond Myklebust , "J. Bruce Fields" , Benjamin Coddington , Al Viro , Jeff Layton , "Eric W. Biederman" Date: Fri, 06 Feb 2015 08:01:03 +0800 In-Reply-To: <12219.1423148468@warthog.procyon.org.uk> References: <20150205023404.8382.41937.stgit@pluto.fritz.box> <20150205021553.8382.16297.stgit@pluto.fritz.box> <12219.1423148468@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 694 Lines: 20 On Thu, 2015-02-05 at 15:01 +0000, David Howells wrote: > Ian Kent wrote: > > > -call_usermodehelper(char *path, char **argv, char **envp, int wait); > > +call_usermodehelper(char *path, char **argv, char **envp, int flags); > > Can we make flags unsigned whilst we're at it? Other than that: Sure, thanks for your comments, here and elsewhere, I'll get onto fixing them. > > Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/