Message-ID: <54D40DAF.4080609@codeaurora.org>
Date: Thu, 05 Feb 2015 16:41:19 -0800
From: Laura Abbott <lauraa@codeaurora.org>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Gregory Fong <gregory.0xf0@gmail.com>,
        linux-arm-kernel@lists.infradead.org
CC: f.fainelli@gmail.com, vishnu.ps@samsung.com,
        Russell King <linux@arm.linux.org.uk>, Nicolas Pitre <nico@linaro.org>,
        Kees Cook <keescook@chromium.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Yalin Wang <Yalin.Wang@sonymobile.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: print cma-reserved pages from show_mem
References: <1423092164-9145-1-git-send-email-gregory.0xf0@gmail.com>
In-Reply-To: <1423092164-9145-1-git-send-email-gregory.0xf0@gmail.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1537
Lines: 47

On 2/4/2015 3:22 PM, Gregory Fong wrote:
> Add cma reserved information to the ARM-specific show_mem.  It was
> added to the generic implementation by commit
> 49abd8c28046adf77c5ce1949549aa64d7221881 "lib/show_mem.c: add cma
> reserved information".
>
> Signed-off-by: Gregory Fong <gregory.0xf0@gmail.com>
> ---
>   arch/arm/mm/init.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 2495c8c..da77507 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -22,6 +22,7 @@
>   #include <linux/memblock.h>
>   #include <linux/dma-contiguous.h>
>   #include <linux/sizes.h>
> +#include <linux/cma.h>
>
>   #include <asm/cp15.h>
>   #include <asm/mach-types.h>
> @@ -130,6 +131,9 @@ void show_mem(unsigned int filter)
>   	printk("%d pages of RAM\n", total);
>   	printk("%d free pages\n", free);
>   	printk("%d reserved pages\n", reserved);
> +#ifdef CONFIG_CMA
> +	printk("%lu cma reserved pages\n", totalcma_pages);
> +#endif

Nit: 'cma reserved pages' is a bit unclear. Are there some CMA
pages that aren't reserved? Dropping the reserved might be
clearer.

Thanks,
Laura

-- 
Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/