Message-ID: <1423211313.1729.15.camel@rzhang1-mobl4>
Subject: Re: [PATCH] thermal: int340x: fix sparse warning
From: Zhang Rui <rui.zhang@intel.com>
To: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cc: Eduardo Valentin <edubezval@gmail.com>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date: Fri, 06 Feb 2015 16:28:33 +0800
In-Reply-To: <1423143817-16128-1-git-send-email-prabhakar.csengg@gmail.com>
References: <1423143817-16128-1-git-send-email-prabhakar.csengg@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1447
Lines: 39

On Thu, 2015-02-05 at 13:43 +0000, Lad Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
> 
> this patch fixes following sparse warning:
> 
> processor_thermal_device.c:188:6: warning: symbol 'proc_thermal_remove' was not declared. Should it be static?
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

applied. thanks!

-rui
> ---
>  Found this issue on linux-next (gcc  version 4.9.2,
>  sparse version  0.4.5-rc1)and applies on top linux-next.
> 
>  drivers/thermal/int340x_thermal/processor_thermal_device.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/int340x_thermal/processor_thermal_device.c b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> index 0fe5dbb..095acac 100644
> --- a/drivers/thermal/int340x_thermal/processor_thermal_device.c
> +++ b/drivers/thermal/int340x_thermal/processor_thermal_device.c
> @@ -185,7 +185,7 @@ free_buffer:
>  	return ret;
>  }
>  
> -void proc_thermal_remove(struct proc_thermal_device *proc_priv)
> +static void proc_thermal_remove(struct proc_thermal_device *proc_priv)
>  {
>  	sysfs_remove_group(&proc_priv->dev->kobj,
>  			   &power_limit_attribute_group);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/