Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755063AbbBFJM2 (ORCPT ); Fri, 6 Feb 2015 04:12:28 -0500 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:20762 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754569AbbBFJMY (ORCPT ); Fri, 6 Feb 2015 04:12:24 -0500 X-IronPort-AV: E=Sophos;i="5.09,528,1418079600"; d="scan'208";a="120535840" Date: Fri, 6 Feb 2015 10:12:22 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Quentin Lambert cc: Stephen Boyd , Mike Turquette , Julia Lawall , Paul Walmsley , Tomeu Vizoso , Tony Lindgren , linux-kernel@vger.kernel.org, t-kristo@ti.com, linux-omap@vger.kernel.org, cocci@systeme.lip6.fr, linux-arm-kernel@lists.infradead.org Subject: Re: [Cocci] [PATCH v13 3/6] clk: Make clk API return per-user struct clk instances In-Reply-To: <54D482EE.6050004@gmail.com> Message-ID: References: <1422011024-32283-1-git-send-email-tomeu.vizoso@collabora.com> <1422011024-32283-4-git-send-email-tomeu.vizoso@collabora.com> <20150201212432.22722.70917@quantum> <54CFE1FE.7040404@codeaurora.org> <54CFFBCF.90706@codeaurora.org> <20150202225036.421.43421@quantum> <54D0F179.1040906@gmail.com> <54D2AA9B.7010800@codeaurora.org> <54D3900A.9060200@gmail.com> <54D423C3.9030105@codeaurora.org> <54D482EE.6050004@gmail.com> User-Agent: Alpine 2.10 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1485 Lines: 38 On Fri, 6 Feb 2015, Quentin Lambert wrote: > > On 06/02/2015 03:15, Stephen Boyd wrote: > > Thanks for the coccinelle patch. Thinking more about it, I don't think > > we care if the pointer is dereferenced because that would require a > > definition of struct clk and that is most likely not the case outside of > > the clock framework. Did you scan the entire kernel? > No I haven't. > > I'm running it now > > but it seems to be taking a while. > > > Yes, that's why, as a first step, I chose to limit the scan to the arm > directory. Are you sure to be using all of the options provided: // Options: --recursive-includes --relax-include-path // Options: --include-headers-for-types And are you using 1.0.0-rc23 or 1.0.0-rc24? Those should save parsed header files so that they don't have to be parsed over and over. If you are using rc24, then you can use the -j option for parallelism. But then you should also use an option like --chunksize 10 (I don't know what number would be good), because the default is chunksize 1, and in that case the saved parsed header files are not reused, because the fies are all processed individually. In general, it is only the files within a chunk that will share parsed header files. julia -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/