Date: Fri, 6 Feb 2015 11:01:34 +0000
From: Wei Liu <wei.liu2@citrix.com>
To: Bob Liu <bob.liu@oracle.com>
CC: Roger Pau =?iso-8859-1?Q?Monn=E9?= <roger.pau@citrix.com>,
        <xen-devel@lists.xen.org>, <david.vrabel@citrix.com>,
        <linux-kernel@vger.kernel.org>, <konrad.wilk@oracle.com>,
        <boris.ostrovsky@oracle.com>, <wei.liu2@citrix.com>
Subject: Re: [PATCH 2/2] drivers: xen/block: add multi-page ring support
Message-ID: <20150206110134.GC30821@zion.uk.xensource.com>
References: <1422008071-27643-1-git-send-email-bob.liu@oracle.com>
 <1422008071-27643-2-git-send-email-bob.liu@oracle.com>
 <54CF54CB.70008@citrix.com>
 <54D49BB5.5000708@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <54D49BB5.5000708@oracle.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1590
Lines: 41

On Fri, Feb 06, 2015 at 06:47:17PM +0800, Bob Liu wrote:
> 
> On 02/02/2015 06:43 PM, Roger Pau Monn? wrote:
> > El 23/01/15 a les 10.14, Bob Liu ha escrit:
> >> Extend xen/block to support multi-page ring.
> >>  * xen-blkback notify blkfront with feature-multi-ring-pages
> >>  * xen-blkfront write to xenstore about how many pages are used as the ring
> >>
> >> If using 4 pages as the ring, inflight requests inscreased from 32 to 128 and
> >> IOPS improved nearly 400% on our system.
> >>
> >> Signed-off-by: Bob Liu <bob.liu@oracle.com>
> >> ---
> >>  drivers/block/xen-blkback/xenbus.c |   86 +++++++++++++++++++++++++--------
> >>  drivers/block/xen-blkfront.c       |   94 ++++++++++++++++++++++++++----------
> > 
> > This requires a patch to xen/include/public/io/blkif.h in the Xen
> > repository describing how this protocol extension is going to work
> > before reviewing the Linux implementation.
> > 
> 
> But there is no protocol change, just add an parameter "max_ring_pages"
> to control how many pages can be used as the ring. Now with one page we
> can only have 32 requests.
> 

I think Roger meant the xenbus protocol used to negotiate this feature,
not the data protocol regarding how request and response are
interpreted. Blkif.h (and netif.h FWIW) has section to describe xenbus
protocol.

Wei.

> -- 
> Regards,
> -Bob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/