Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585AbbBFL2w (ORCPT ); Fri, 6 Feb 2015 06:28:52 -0500 Received: from mail-pd0-f172.google.com ([209.85.192.172]:45622 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751094AbbBFL2t (ORCPT ); Fri, 6 Feb 2015 06:28:49 -0500 Date: Fri, 6 Feb 2015 03:28:45 -0800 From: Brian Norris To: Richard Weinberger Cc: Julia Lawall , Kukjin Kim , "kernel-janitors@vger.kernel.org" , linux@rasmusvillemoes.dk, Joe Perches , David Woodhouse , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc@vger.kernel.org, "linux-mtd@lists.infradead.org" , LKML Subject: Re: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string Message-ID: <20150206112845.GF4434@norris-Latitude-E6410> References: <1417980062-25151-1-git-send-email-Julia.Lawall@lip6.fr> <1417980062-25151-2-git-send-email-Julia.Lawall@lip6.fr> <54856C75.1050309@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54856C75.1050309@nod.at> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2490 Lines: 71 On Mon, Dec 08, 2014 at 10:16:37AM +0100, Richard Weinberger wrote: > Am 08.12.2014 um 08:11 schrieb Julia Lawall: > >>> diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c > >>> index 35aef5e..0a9c41f 100644 > >>> --- a/drivers/mtd/nand/s3c2410.c > >>> +++ b/drivers/mtd/nand/s3c2410.c > >>> @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) > >>> > >>> cpu_type = platform_get_device_id(pdev)->driver_data; > >>> > >>> - pr_debug("s3c2410_nand_probe(%p)\n", pdev); > >>> + pr_debug("%s(%p)\n", __func__, pdev); > >> > >> I think we can drop the line completely. > >> We have ftrace to trace function calls... > > > > Should the "initialised ok" at the end of the function be remove as well? > > > > Will it be confusing if this cleanup is done in this function, but not in > > others where it may be useful? Perhaps s3c2410_nand_update_chip, for > > example? > > Hmm, this driver seems to have a lot of debugging printks(). > IMHO we can remove them. > Let's see what Brain says. I'm a little late for this one, but I can apply this instead: From: Brian Norris Date: Fri, 6 Feb 2015 03:25:28 -0800 Subject: [PATCH] mtd: s3c2410: drop useless / misspelled debug prints s3c2410_nand_probe is not the name of the function. These prints have little utility, so let's just kill them. Reported-by: Julia Lawall Signed-off-by: Brian Norris --- drivers/mtd/nand/s3c2410.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c index 35aef5edb588..0e02be47ce1d 100644 --- a/drivers/mtd/nand/s3c2410.c +++ b/drivers/mtd/nand/s3c2410.c @@ -948,8 +948,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) cpu_type = platform_get_device_id(pdev)->driver_data; - pr_debug("s3c2410_nand_probe(%p)\n", pdev); - info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL); if (info == NULL) { err = -ENOMEM; @@ -1045,7 +1043,6 @@ static int s3c24xx_nand_probe(struct platform_device *pdev) s3c2410_nand_clk_set_state(info, CLOCK_SUSPEND); } - pr_debug("initialised ok\n"); return 0; exit_error: -- 2.3.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/