Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755534AbbBFMws (ORCPT ); Fri, 6 Feb 2015 07:52:48 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:50368 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbbBFMwr (ORCPT ); Fri, 6 Feb 2015 07:52:47 -0500 Message-ID: <54D4B911.2050601@oracle.com> Date: Fri, 06 Feb 2015 20:52:33 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Wei Liu CC: =?ISO-8859-1?Q?Roger_Pau_Monn=E9?= , xen-devel@lists.xen.org, david.vrabel@citrix.com, linux-kernel@vger.kernel.org, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com Subject: Re: [PATCH 2/2] drivers: xen/block: add multi-page ring support References: <1422008071-27643-1-git-send-email-bob.liu@oracle.com> <1422008071-27643-2-git-send-email-bob.liu@oracle.com> <54CF54CB.70008@citrix.com> <54D49BB5.5000708@oracle.com> <20150206110134.GC30821@zion.uk.xensource.com> In-Reply-To: <20150206110134.GC30821@zion.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1728 Lines: 45 On 02/06/2015 07:01 PM, Wei Liu wrote: > On Fri, Feb 06, 2015 at 06:47:17PM +0800, Bob Liu wrote: >> >> On 02/02/2015 06:43 PM, Roger Pau Monn? wrote: >>> El 23/01/15 a les 10.14, Bob Liu ha escrit: >>>> Extend xen/block to support multi-page ring. >>>> * xen-blkback notify blkfront with feature-multi-ring-pages >>>> * xen-blkfront write to xenstore about how many pages are used as the ring >>>> >>>> If using 4 pages as the ring, inflight requests inscreased from 32 to 128 and >>>> IOPS improved nearly 400% on our system. >>>> >>>> Signed-off-by: Bob Liu >>>> --- >>>> drivers/block/xen-blkback/xenbus.c | 86 +++++++++++++++++++++++++-------- >>>> drivers/block/xen-blkfront.c | 94 ++++++++++++++++++++++++++---------- >>> >>> This requires a patch to xen/include/public/io/blkif.h in the Xen >>> repository describing how this protocol extension is going to work >>> before reviewing the Linux implementation. >>> >> >> But there is no protocol change, just add an parameter "max_ring_pages" >> to control how many pages can be used as the ring. Now with one page we >> can only have 32 requests. >> > > I think Roger meant the xenbus protocol used to negotiate this feature, > not the data protocol regarding how request and response are > interpreted. Blkif.h (and netif.h FWIW) has section to describe xenbus > protocol. > Oh, I see. Sorry for the misunderstood. Also will fix the indentation issue of the first patch. Thanks, -Bob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/