Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754479AbbBFOdF (ORCPT ); Fri, 6 Feb 2015 09:33:05 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:41998 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752951AbbBFOdC (ORCPT ); Fri, 6 Feb 2015 09:33:02 -0500 Date: Fri, 6 Feb 2015 20:02:51 +0530 From: Sudip Mukherjee To: Rickard Strandqvist Cc: Dan Carpenter , "devel@driverdev.osuosl.org" , Chaitanya Hazarey , Greg Kroah-Hartman , Peter P Waskiewicz Jr , Linux Kernel Mailing List , Greg Donald , Koray Gulcu Subject: Re: [PATCH v2] staging: rtl8192u: r8192U_core: Fix for possible null pointer dereference Message-ID: <20150206143250.GA21554@sudip-PC> References: <1422557952-4209-1-git-send-email-rickard_strandqvist@spectrumdigital.se> <20150205122745.GF5336@mwanda> <20150205124322.GA8137@sudip-PC> <20150205125124.GG5336@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1172 Lines: 34 On Thu, Feb 05, 2015 at 06:39:13PM +0100, Rickard Strandqvist wrote: > 2015-02-05 13:51 GMT+01:00 Dan Carpenter : > > On Thu, Feb 05, 2015 at 06:13:22PM +0530, Sudip Mukherjee wrote: > >> if (driver_info) { > >> stats->RxIs40MHzPacket = driver_info->BW; > >> if (stats->RxDrvInfoSize != 0) > >> TranslateRxSignalStuff819xUsb(skb, stats, driver_info); > >> } > > > > If driver_info is non-NULL then stats->RxDrvInfoSize is not zero and > > also the reverse. So really you only need to test one. > > > > regards, > > dan carpenter > > > > True Dan > > Okay, I'll make one last patch then, or if you want to do it Sudip? > Have you not done before Saturday I do it. no, its yours. you found it so credit should be yours. I am sure Greg will accept this one. If he drops then maybe I can re-send with you as Reported-by regards Sudip > > Kind regards > Rickard Strandqvist -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/