Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755356AbbBFOdz (ORCPT ); Fri, 6 Feb 2015 09:33:55 -0500 Received: from mail-la0-f47.google.com ([209.85.215.47]:45061 "EHLO mail-la0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755264AbbBFOdx (ORCPT ); Fri, 6 Feb 2015 09:33:53 -0500 From: Rasmus Villemoes To: Kashyap Desai , Sumit Saxena , Uday Lingala , "James E.J. Bottomley" Cc: Rasmus Villemoes , megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] scsi: megaraid_sas: Prevent future %p disaster Date: Fri, 6 Feb 2015 15:33:41 +0100 Message-Id: <1423233221-27069-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1369 Lines: 32 There is currently no %po format extension, so currently the letters "on" are simply skipped and the pointer is printed as expected (while missing the word on). However, it is probably only a matter of time before someone comes up with a %po extension, at which point this is likely to fail spectacularly. Signed-off-by: Rasmus Villemoes --- drivers/scsi/megaraid/megaraid_sas_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index ff283d23788a..e7c6b9c946d6 100644 --- a/drivers/scsi/megaraid/megaraid_sas_base.c +++ b/drivers/scsi/megaraid/megaraid_sas_base.c @@ -3105,7 +3105,7 @@ megasas_internal_reset_defer_cmds(struct megasas_instance *instance) for (i = 0; i < max_cmd; i++) { cmd = instance->cmd_list[i]; if (cmd->sync_cmd == 1 || cmd->scmd) { - printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p" + printk(KERN_NOTICE "megasas: moving cmd[%d]:%p:%d:%p " "on the defer queue as internal\n", defer_index, cmd, cmd->sync_cmd, cmd->scmd); -- 2.1.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/